joealcorn / xbox

Python wrapper around Microsoft's undocumented Xbox one APIs

Home Page:http://xbox.readthedocs.org/en/latest/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

__getattr__ of DotNotationDict should raise AttributeError

svisser opened this issue · comments

For correctness, the __getattr__ method of DotNotationDict needs to raise an AttributeError when the attribute does not exist. Otherwise, you can't write getattr(my_dict, 'attr_does_not_exit', 100) (it'll raise KeyError, it won't return to you the default value).

Right you are, thanks