Giters

jobbyphp / jobby

Manage all your cron jobs without modifying crontab. Handles locking, logging, error emails, and more.

Home Page:https://packagist.org/packages/hellogerard/jobby

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Extract Swift mailer capability to new package

fezfez opened this issue · comments

commented

Hi,

I would like to drop the swiftmailer/swiftmailer dependencies from this package.

To achieve this i propose to add a new interface JobbyNotifier such has :

<?php 

namespace Jobby;

interface JobbyNotifier
{
    /**
     * @param string $job
     * @param string $message
     *
     * @return void
     */
    public function sendMessage($job, $message)
}

and new repo such has jobbyphp/jobby-swiftmailer.

the jobbyphp/jobby package could suggest to install jobbyphp/jobby-swiftmailer for mails capability.

A good alternative will be to add symfony/notifier but this will drop php 5.6, 7.0, 7.1.

How do you feel about this proposal ?

Thanks

commented

I like the idea, because it will allow to use custom mailing script if I understood it correctly?

So for example I can call my own _mail function?

commented

Yes exactly

commented

Hi @fezfez,

Would you be able to submit a pr for this?

commented

why you don't use phpmailer?

commented

@fezfez Wondering if you did any work on this? I'm seeing messages that swiftmailer is abandoned and should be replaced and just started to look into it. They appear to be recommending Symfony Mailer as the replacement. Regardless, I'd like to help if I can.