Giters

joaoh82 / rust_sqlite

SQLRite - Simple embedded database modeled off SQLite in Rust

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rethink of project logic

joshbenaron opened this issue · comments

commented

Hey,
I was just starting to implement the SELECT query of the engine and I guess I've been thinking about the overall approach. At the moment it seems to be very modular (which isn't actually bad when it comes to abstracting over the engine). Parse query -> Parse to structs -> Execute. I think we should remove the middle step and go straight to execution. This would mean fewer allocations along the line. So basically take sqlparser's output and just use that in execution
I'd love to know what you think.

commented

I like the idea of having fewer allocations. Definitely decreasing possible failure points.

Btw, I created a discord server for the project so we can start have a more active conversation and build a community. Here is the link: https://discord.gg/zHXUG66X .

commented

I like the idea of having fewer allocations. Definitely decreasing possible failure points.

Btw, I created a discord server for the project so we can start have a more active conversation and build a community. Here is the link: https://discord.gg/zHXUG66X .

@joaoh82 Hey sorry, I just saw this. Can you send an updated link, please?