Deployment Documentation Nitpick
big-c-note opened this issue · comments
bigc commented
Hey Jon, quick nitpick in case it helps your new users. Thanks for the tutorial.
Under Build and Deploy Locally and Quickstart in the README:
You should be able to visit http://hellokubecon.juju in your browser.
The previous instructions deploy to http://hello-kubecon
Based on falling back to the app name due to no external hostname set and then running
# Add an entry to /etc/hosts
$ echo "127.0.1.1 hello-kubecon" | sudo tee -a /etc/hosts
(PR: #7 )
Alternatively, update external hostname to "hellokubecon.juju"
and change readme to:
# Add an entry to /etc/hosts
$ echo "127.0.1.1 hellokubecon.juju" | sudo tee -a /etc/hosts
which would be more consistent with your tutorial/slides. lmk if you'd prefer that, happy to spin up a quick pr.