jmacdonald / amp

A complete text editor for your terminal.

Home Page:https://amp.rs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fail build from aur

xoac opened this issue · comments

I have tried to build from AUR with pamac build amp cmd and it fail:

   Compiling url v1.7.0
error[E0713]: borrow may still be in use when destructor runs
   --> /home/sr/.cargo/registry/src/github.com-1ecc6299db9ec823/url-1.7.0/src/form_urlencoded.rs:261:40
    |
259 | impl<'a> Target for ::UrlQuery<'a> {
    |      -- lifetime `'a` defined here
260 |     fn as_mut_string(&mut self) -> &mut String { &mut self.url.serialization }
261 |     fn finish(self) -> &'a mut ::Url { self.url }
    |                                        ^^^^^^^^ - here, drop of `self` needs exclusive access to `*self.url`, because the type `UrlQuery<'_>` implements the `Drop` trait
    |                                        |
    |                                        returning this value requires that `*self.url` is borrowed for `'a`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0713`.

Versions:

~ >>> rustc --version -v                                                       
rustc 1.40.0 (73528e339 2019-12-16)
binary: rustc
commit-hash: 73528e339aae0f17a15ffa49a8ac608f50c6cf14
commit-date: 2019-12-16
host: x86_64-unknown-linux-gnu
release: 1.40.0
LLVM version: 9.0
~ >>> cargo --version -v                                                       
cargo 1.40.0 (bc8e4c8be 2019-11-22)
release: 1.40.0
commit-hash: bc8e4c8be13c8f8d1583f9d52e55fda038c0f9d4
commit-date: 2019-11-22
~ >>> rustup --version -v                                                      
rustup 1.20.2 (2019-10-16)

cargo install amp worked as expected

Hi @xoac! Thanks for filing this. I've made some updates since releasing 0.6.0 that update the url crate as a side-effect; I'll issue a 0.6.1 release and will bump the AUR package.

Okay, 0.6.1 has landed and the AUR package has been updated. Thanks again, @xoac!