jmacdonald / amp

A complete text editor for your terminal.

Home Page:https://amp.rs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Feature Request] Support for LibreSSL 3.0.0

jesselucas opened this issue · comments

Attempting to build amp on OpenBSD 6.6 and receive the following error:

error: failed to run custom build command for `openssl-sys v0.9.40`
thread 'main' panicked at '

This crate is only compatible with OpenSSL 1.0.1 through 1.1.1, or LibreSSL 2.5
through 2.9.0, but a different version of OpenSSL was found. The build is now aborting
due to this version mismatch.

That error comes from the openssl-sys crate, which is deprecated. The replacement, openssl, supports the same versions though.

Which openssl version do you have? Try with openssl version -a

 ~$ openssl version -a
LibreSSL 3.0.0
built on: date not available
platform: information not available
options:  bn(64,64) rc4(16x,int) des(idx,cisc,16,int) idea(int) blowfish(idx)
compiler: information not available
OPENSSLDIR: "/etc/ssl"

Apparently OpenSSL does support LibreSSL 3.0: sfackler/rust-openssl#1121
They probably haven't updated the readme. It's a matter of switching crates here then

Amp uses very little of the git2 crate. I've opted to simply remove its default features, one of which was SSH support, which in turn set a dependency on openssl. That should fix this particular build issue, as a side effect. Do let us know if this is the only build issue you encounter; I'm curious to see if it'll build on OpenBSD now.

Thank you! Now the build is running into an error locating libxcb. It's part of the base X and located in /usr/X11R6/lib/libxcb.a . Guessing the dependency https://github.com/rtbo/rust-xcb/ might need to add support for locating libxcb on OpenBSD?