Compiling in MSVC 2013

Question

Compiling in MSVC 2013

fuzzac opened this issue 8 years ago · comments

Hi,

I've been trying to compile xdelta in Visual Studio 2013 and ran into a number off issues with e.g. inlined functions, missing SIZEOF_SIZE_T define, __attribute__ not supported in MSVC and some Posix function that doesn't exist on Windows. Is Visual Studio still supported for xdelta?

Thanks in advance.

zdunker · Answer 1 · Sat Jul 23 2016 01:47:07 GMT+0800 (China Standard Time)

I ran into the same issue, may I ask how you solved this? Thank you.

dozenow · Answer 2 · Sat Jul 23 2016 05:35:06 GMT+0800 (China Standard Time)

@zdunker I had this problem and gave up using visual studio. Finally, I switched to use mingw64 to compile it on Windows. It works.

Oscar King · Answer 3 · Wed Sep 07 2016 17:52:06 GMT+0800 (China Standard Time)

I have the same problem, too, but I'm using VS2015. When open xdelta3.vcxproj and compile will get:
xdelta3.h(243): fatal error C1189: #error: Bad configure script

I checked the compile options in Debug|Win32 C/C++ -> General -> Additional Include Direcories, there is ../xz/include.

Is some file missed in the github? Also I can't find the config.h :(

psikorski · Answer 4 · Fri May 26 2017 19:01:31 GMT+0800 (China Standard Time)

I still see that problem. Any advice on resolving it for VS2015?

Philippe Lieser · Answer 5 · Thu Jun 01 2017 20:47:12 GMT+0800 (China Standard Time)

I was able to build it under VS2013. See #231 for what I changed.

plaska-verys · Answer 6 · Tue Jun 09 2020 04:47:05 GMT+0800 (China Standard Time)

Sorry to necro such an old thread. However, it is June 8, 2020, and this issue still exists in every Visual Studio build except the Win32 | Debug build, when using the xdelta3.vcxproj project. I just ran into it myself. The reason it works in the one project, is that it has SIZEOF_SIZE_T defined in the PreprocessorDefinitions for that build configuration.

If anyone is attempting to use the Visual Studio project, and needs to get past this issue, just define SIZEOF_SIZE_T appropriately for your build configuration in the C++ Preprocessor Definitions properties.

Same issue goes for SIZEOF__UNSIGNED_LONG_LONG.

~~I may see about submitting a PR, but since I'm fairly new to xdelta, I have no idea if it will be accepted.~~ Yeah, I don't see any options to ask for contribution/commit access (e.g. in the README.md), nor an option to create a branch to submit a PR on (e.g. in the GitHub dropdown). I'm guessing the project is not open to community contributions. Anyway, I opened a ticket:
#258