Install on fish gives Warning
IanVaughan opened this issue · comments
From the readme :
$ set -gx PATH "~/.tmuxifier/bin" $PATH
set: Warning: path component ~/.tmuxifier/bin may not be valid in PATH.
set: No such file or directory
$ fish -v
fish, version 2.1.0
It doesn't seem to be a problem, but I thought I'd raise it anyway.
I don't use Fish myself. @trekdemo would you be able to chime in on this? Otherwise I'll properly look into it myself later today/tomorrow.
Hi @IanVaughan,
Does the ~/.tmuxifier/bin/tmuxifier
file exist?
I did a bit of digging around and found that the README is wrong.
- The quotes should not be used.
➜ ~ ⮀ set -gx PATH "~/.tmuxifier/bin" $PATH
set: Warning: path component ~/.tmuxifier/bin may not be valid in PATH.
set: No such file or directory
➜ ~ ⮀ set -gx PATH ~/.tmuxifier/bin $PATH
(ok)
So the README needs changing :
- set -gx PATH "~/.tmuxifier/bin" $PATH
+ set -gx PATH ~/.tmuxifier/bin $PATH
Then maybe add a note to add this line to the ~/.config/fish/config.fish
for subsequent reboots etc.
- If you want to change the layout location, then the following needs to be ran
set -Ux TMUXIFIER_LAYOUT_PATH ~/dotfiles/tmuxifier/layouts/
(Obviously changing the last path bit to what's required)
Using U
sets it Universal, so it does not need to be set ever again, thus no need to add it to a config file, which is neat.
If a user would prefer using the config file, then they can use
set -x TMUXIFIER_LAYOUT_PATH ~/dotfiles/tmuxifier/layouts/
PS. Thanks for chipping in @trekdemo
Interesting @IanVaughan. Would you mind maybe supplying a PR with the changes? :)
As for the universal set thing, I don't know what convention is with Fish, but I'd imagine declarative/obvious configs are better than the opposite, right? lol