jichu4n / fish-command-timer

Fish shell extension for printing execution time for each command.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

fish 3.2.1 breaks call to `__fish_status_to_signal` function

lpzantony opened this issue · comments

After updating to fish 3.2.1 this morning, I noticed an error while executing any command in my fish shell:

> ls ~/.config/fish
fish: Unknown command: __fish_status_to_signal
~/.config/fish/conf.d/fish_command_timer.fish (line 1): 
__fish_status_to_signal $last_status
^
in command substitution
	called on line 243 of file ~/.config/fish/conf.d/fish_command_timer.fish
in function 'fish_command_timer_postexec' with arguments 'ls\ \~/.config/fish/'
in event handler: handler for generic event “fish_postexec”
~/.config/fish/conf.d/fish_command_timer.fish (line 243): Unknown error while evaluating command substitution
    set -l signal (__fish_status_to_signal $last_status)
                  ^
in function 'fish_command_timer_postexec' with arguments 'ls\ \~/.config/fish/'
in event handler: handler for generic event “fish_postexec”

I noticed that updating line 243 of fish_command_timer.fish fixes the issue:

# Before my edit
    set -l signal (__fish_status_to_signal $last_status)
# After my edit
    set -l signal (fish_status_to_signal $last_status)

It seems that I can't create a branch on this repo, thus I can't create a pull request, this is why I am creating this issue.

Regards

AL

Thanks - merged fix PR #26 .