jhump / protoreflect

Reflection (Rich Descriptors) for Go Protocol Buffers

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

possible regression from v1.15.0

tmc opened this issue · comments

The api-linter tool starts failing for me if i update protoreflect to v1.15.0 with messages like:

2023/03/01 15:35:55 interface conversion: protoreflect.List is *dynamicpb.dynamicList, not *impl.listReflect; interface conversion: protoreflect.List is *dynamicpb.dynamicList, not *impl.listReflect; interface conversion: protoreflect.List is *dynamicpb.dynamicList, not *
impl.listReflect; interface conversion: protoreflect.List is *dynamicpb.dynamicList, not *impl.listReflect; interface conversion: protoreflect.List is *dynamicpb.dynamicList, not *impl.listReflect; interface conversion: protoreflect.List is *dynamicpb.dynamicList, not *im
pl.listReflect; interface conversion: protoreflect.List is *dynamicpb.dynamicList, not *impl.listReflect; interface conversion: protoreflect.List is *dynamicpb.dynamicList, not *impl.listReflect; interface conversion: protoreflect.List is *dynamicpb.dynamicList, not *impl
.listReflect

See here for a sample run attempting to update this library.

@tmc, do you have the ability to test an unreleased commit? I think this regression should now be fixed, as of #554. Can you confirm? If you can, and it is indeed fixed, I can cut a v1.15.1 ASAP.

@tmc, do you have the ability to test an unreleased commit? I think this regression should now be fixed, as of #554. Can you confirm? If you can, and it is indeed fixed, I can cut a v1.15.1 ASAP.

Yes certainly. Will test now.

7923b75 does fix this issue in google's api-linter!

@tmc, thanks for testing. I will make a release later today.

Fixed in v1.15.1.