CRAN submission issue
jhrcook opened this issue · comments
@torfason I tried to submit the latest version of 'mustashe' to CRAN a while back, but it got rejected because during the test-running process, it was leaving behind a .mustashe directory somewhere. I couldn't reproduce the issue on my computer and didn't have the bandwidth to pursue it further at the time. If memory serves, I recall it was only an issue on CRAN's linux servers, so I've been meaning to try the R CMD process on a linux computer I have access to, but just haven't gotten around to it yet.
Just wanted to update you on this because I feel bad that the latest features you've contributed haven't been distributed yet. It is on my list of things to do though. I apologize it has taken so long.
This reproduces on my Mac (that is, a .mustashe directory was left behind after running tests), but perhaps it is only the linux build servers on CRAN that complain about such file system littering.
But anyway, I submitted a PR that should fix this, PR #37
This PR uses testthat test fixtures, which are the recommended way of running code after all tests are done. This adds a dependency on withr (but testthat itself depends on withr, so this should not be an issue). See:
This is all done in the file tests/testthat/setup.R. In that file, I also added a check to abort tests if the .mustashe directory is found, because if there is something valuable there it seems a bit dangerous to just delete it.
In the long run, a more elegant solution would be to ensure that each test cleans up after itself, but that's quite a bit of work, and not justified just to get the release through CRAN. This would in any case entail the same code (check if directory is found, abort if it is, otherwise register a deferred deletion), just for each individual test.
Hopefully this will satisfy CRAN :-)
And no worries about the release – I've had the exact same issue with a package I'm maintaining, of not being able to release a new version because of CRAN issues that are totally unrelated to the changes in that version. It is what it is, but as I said, here's hoping that with these changes CRAN will be pleased ...
It seems that mustashe was removed from CRAN in January due to failed check results :-(
https://cran-archive.r-project.org/web/checks/2024/2024-01-23_check_results_mustashe.html
I think it would be a shame if it disappeared, because it fills a nice niche. Do you have any plans related to that – either to submit a new release or to open up to a new co-maintainer?
@torfason I don't really use R much any more nor have the time to devote to maintaining 'mustashe' but I wouldn't mind adding you as a co-maintainer. What permissions on GitHub do you think would be appropriate? And do you know how I can add you as a maintainer on CRAN so you can handle submissions?
It is worth noting that I think this package can still be installed from GitHub.