Giters

jhipster / jhipster-lite

JHipster Lite ⚡ is a development platform to generate, develop & deploy modern web applications & microservices architecture, step by step - using Hexagonal Architecture :gem:

Home Page:https://www.jhipster.tech/jhipster-lite/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add missing gradle frontend server plugin

renanfranca opened this issue · comments

commented

Prerequisites

This sample implemented the following features which is going to be handle by this issue:

  • install the npm inside the build folder
  • npm install
  • npm run build from the package.json
  • npm run test from the package.json
  • add the frontend build project inside the .jar

To test the sample:

  1. ./gradlew clean build --no-daemon --info (will generate the .jar at build/libs folder)
  2. java -jar build/libs/jhipster-sample-application-0.0.1-SNAPSHOT.jar (access the frontend at http://localhost:8080)
  3. docker compose -f src/main/docker/sonar.yml up -d and ./gradlew clean build sonar --info (all frontend tests will be at sonar with 100% coverage)

Sharing what I learned after a long time dedicated:

commented

@murdos and @atomfrede: please let me know WDYT ;)

commented

I will try to do a proper review later today. Thanks for putting the efforts into this 👍

commented

@renanfranca Looks quite fine from what I can tell. For the node/npm tasks you might consider defining proper inputs and outputs to make caching (both local or via develocity) possible

commented

Thank you for the feedback 😊

For the node/npm tasks you might consider defining proper inputs and outputs to make caching (both local or via develocity) possible

Can you detail which inputs and outputs (local/develocity)?

commented
  • Angular doesn't work with the Maven front-end plugin or with Gradle edit: when run the generated .jar. I didn't try react

I tried gradle with vue and react as frontend and they are working with the implementation at draft pull request #9825

I tried angular and it isn't working. I have to look into it.

commented

I am in the process of removing gradleapp from generator.sh and replacing it with fullapp using the Gradle build tool. To see the steps I need to take to accomplish this, please check out this pull request.

Edit: I am going to do this in another issue/pull request to separate things

commented

You can claim the bounty of this ticket @renanfranca , in addition of the specific ones in each PRs , as it was a huge work to improve gradle support

Thanks so much for your work

commented

You can claim the bounty of this ticket @renanfranca , in addition of the specific ones in each PRs , as it was a huge work to improve gradle support

Thanks so much for your work

Thank you very much for the support and recognition. The quality of the code will continue to be my priority 😃✌️