UserService activateRegistration method didn't set activation key properly

[Kevin H.A Tan]

Overview of the issue

Reproduce the error

1. Go through register
2. Go through activation
3. Login will be unsuccessful.

Related issues

N/A

Suggest a Fix

public Optional<User> activateRegistration(String key) {
    log.debug("Activating user for activation key {}", key);
    return userRepository
      .findOneByActivationKey(key)
      .map(user -> {
        // activate given user for the registration key.
        user.setActivated(true);
        user.setActivationKey(null);
        this.clearUserCaches(user);
        log.debug("Activated user: {}", user);
        return user;
      });
  }

to

public Optional<User> activateRegistration(String key) {
    log.debug("Activating user for activation key {}", key);
    return userRepository
      .findOneByActivationKey(key)
      .map(user -> {
        // activate given user for the registration key.
        user.setActivated(true);
        user.setActivationKey(key); //the key should be set here.
        this.clearUserCaches(user);
        log.debug("Activated user: {}", user);
        return user;
      });
  }

Project configuration

Any project that doesn't use third party auth.

Entity configuration(s) entityName.json files generated in the .jhipster directory

N/A

Browsers and Operating System

Any

• Checking this box is mandatory (this is just to show you read everything)