go test fails from master

Question

go test fails from master

tegk opened this issue 5 years ago · comments

What I did:
run go test

What I expected:
tests are passing

What I got:
--- FAIL: TestReadHeader (0.00s)
header_test.go:516: Stripped SID value
got : "",
want: "0",
input: "SID : 0\r\n"
header_test.go:516: Stripped Audio Mode value
got : "",
want: "None",
input: "Audio Mode : None\r\n"
header_test.go:516: Stripped Privilege value
got : "",
want: "127",
input: "Privilege : 127\r\n"
FAIL
exit status 1
FAIL github.com/jhillyerd/enmime 0.042s

Release or branch I am using:
master

Neil · Answer 1 · Fri Nov 01 2019 08:44:46 GMT+0800 (China Standard Time)

This is a known issue relating to a bug fix for the textproto package that was introduced in go v1.13.1 and backported to v1.12.10

We have a fix for this in the develop branch
See merged pull request for details

Till Knuesting · Answer 2 · Fri Nov 01 2019 22:41:27 GMT+0800 (China Standard Time)

would you consider a hot-fix or what is your ETA? I am hesitant to use a library where the tests are not working.

James Hillyerd · Answer 3 · Sat Nov 02 2019 08:14:35 GMT+0800 (China Standard Time)

I'm traveling, so I can't make any changes for a couple weeks

…

On Fri, Nov 1, 2019, 11:41 PM Till Knuesting ***@***.***> wrote: would you consider a hot-fix or what is your ETA? I am hesitant to use a library where the tests are not working. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#137?email_source=notifications&email_token=AATDAUCP3T2NFGD7NPTLL6DQRQ5ZPA5CNFSM4JHJCF2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC3DSKY#issuecomment-548813099>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATDAUBU6LQ57OQ42VQECODQRQ5ZPANCNFSM4JHJCF2A> .

James Hillyerd · Answer 4 · Mon Nov 25 2019 03:25:06 GMT+0800 (China Standard Time)

New release has been cut