jhawthorn / discard

🃏🗑 Soft deletes for ActiveRecord done right

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Discarding on nested attributes doesn't trigger callbacks

aried3r opened this issue · comments

Hey!

I read #7 (comment) which is the solution to this particular issue. But one thing that isn't mentioned is that this will not trigger after_discarded callbacks, if any.

I think paper_trail solved this by checking on after_update if any of the tracked attributes were changed, and if so, create a version, run callbacks etc.

Maybe this is a route this gem could also take?

Because this issue is more than a year old, I'm going to close it. It sounds like there might be a real issue worth investigating, though. If you could provide a spec that demonstrates the issue, I'm happy to look into it.