jgarzik / python-bitcoinrpc

Python interface to bitcoin's JSON-RPC API

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Please fix the tag

magnetic-pi opened this issue · comments

Hi there,

I was trying to use pip to install your project based off the tag. I tried the following:

pip install -e git+https://github.com/jgarzik/python-bitcoinrpc.git@v0.3#egg=bitcoinrpc

This kept failing because your actual tag is v0.3-33-ge484743:

pip install -e git+https://github.com/jgarzik/python-bitcoinrpc.git@v0.3-33-ge484743#egg=bitcoinrpc

If you type, "git tag" the tag will appear correctly, however if you run "git describe" on your repo you will see the actual tag. The tag gets into this state if you, cut a tag, and merge something into the existing, after the tag has been set. For more information please see:

https://www.kernel.org/pub/software/scm/git/docs/git-describe.html

I am a release engineer, and I encounter this every release week. :( I added this to my requriements.txt, so if you make any changes, the tag will change to 34 and thus it will break my "pip install -r requirements" command. I'm very big on sharing knowledge, so I hope you don't find this offensive. I just recently found out about this myself.

At work I am trying to get everyone to follow semantic versioning:

http://semver.org/

Perhaps you could just add a 1 at the end of your tag so it would be: 0.3.1

I love the project! Thanks so much for the great work.

Cheers,
Jon