Play Ended Event
jbh630 opened this issue · comments
I have a UWP app that I am refactoring into a ,Net Maui app and I don't see an event to support the Plugin.Naui.Audio audio player file (sound) has completed or ended. In my UWP app this was a MediaEnded event. Is there something in the plugiun that I am not just seeing?
You want the PlaybackEnded event in the AudioPlayer class
I see that the IAudioPlauer interface supports the event but it doesn't fire when the sound completes. Is there something required to make the event fire?
I created an event handler in my code for the PlaybackEnded event but it is never called. How should I incorporate this into my code. In my UWP app I was using the MediaElement_MediaEnded event handler in my code and it worked fine.
… On 12/17/2022 1:19 PM Shaun Lawrence ***@***.***> wrote:
You want the PlaybackEnded event in the AudioPlayer class
—
Reply to this email directly, view it on GitHub #40 (comment) , or unsubscribe https://github.com/notifications/unsubscribe-auth/AO37UDNUH3ULVDS22VY5BN3WNX7ZTANCNFSM6AAAAAATCB33EY .
You are receiving this because you authored the thread.Message ID: ***@***.***>
Looks like it should be triggered: https://github.com/jfversluis/Plugin.Maui.Audio/blob/main/src/Plugin.Maui.Audio/AudioPlayer.windows.cs#L93
Could you maybe put together a small reproduction project on how you're trying to use this to demonstrate the issue?
Thanks!
Hi Gerald,
Thanks for the response. If you download my app from the Microsoft store ("jTuningII") you will see what I am trying to refactor into a .Net Maui app.
I have included the ChordsPage.Xaml.cs code for the new app. I also added the following to the MauiProgram.cs:
builder.Services.AddSingleton(AudioManager.Current);
builder.Services.AddTransient<ChordsPage>();
I included a picture of the page as well.
All the sound files are in the Resources/Raw folder. The sound is activated by tapping on a chord item on the page and it does play the sound correctly. My intent was to add the dispose method for the player in the PlaybackEnded method once I had it working.
Any help would be greatly appreciated.
On 12/18/2022 8:22 AM Gerald Versluis ***@***.***> wrote:
Looks like it should be triggered: https://github.com/jfversluis/Plugin.Maui.Audio/blob/main/src/Plugin.Maui.Audio/AudioPlayer.windows.cs#L93
Could you maybe put together a small reproduction project on how you're trying to use this to demonstrate the issue?
Thanks!
—
Reply to this email directly, view it on GitHub #40 (comment) , or unsubscribe https://github.com/notifications/unsubscribe-auth/AO37UDKENUZ2CKJUQHWUBX3WN4F2VANCNFSM6AAAAAATCB33EY .
You are receiving this because you authored the thread.Message ID: ***@***.***>
using jTuning_I.Models;
using Microsoft.Maui.Controls;
using Plugin.Maui.Audio;
using System.Collections.ObjectModel;
using System.Security.Cryptography.X509Certificates;
namespace jTuning_I.Pages;
public partial class ChordsPage : ContentPage
{
private readonly IAudioManager audioManager;
public List<Sound> chordList;
IAudioPlayer player;
public ChordsPage(IAudioManager audioManager)
{
InitializeComponent();
// Set this to read-only using intellisense
this.audioManager = audioManager;
// Instantiate a List of sounds based on the Chord category
chordList = new List<Sound>();
// Create the list that denotes the image and sound associated with
// the category
chordList = getSounds();
ChordList.ItemsSource = chordList;
}
// This method generates a list of sound items that denote
// the name of both the image and audio files for the category
private List<Sound> getSounds()
{
var sounds = new List<Sound>();
sounds.Add(new Sound("a7_chord"));
sounds.Add(new Sound("a7n_chord"));
sounds.Add(new Sound("am_chord"));
sounds.Add(new Sound("b7_chord"));
sounds.Add(new Sound("bm_chord"));
sounds.Add(new Sound("c_chord"));
sounds.Add(new Sound("c7_chord"));
sounds.Add(new Sound("d_chord"));
sounds.Add(new Sound("d7_chord"));
sounds.Add(new Sound("dm_chord"));
sounds.Add(new Sound("e7_chord"));
sounds.Add(new Sound("em_chord"));
sounds.Add(new Sound("g_chord"));
sounds.Add(new Sound("g7_chord"));
sounds.Add(new Sound("f_chord"));
sounds.Add(new Sound("fsharp7_chord"));
return sounds;
}
private void PlayButton_Click(object sender, EventArgs e)
{
if (player != null)
{
PauseButton.IsVisible = true;
PlayButton.IsVisible = false;
player.Play();
}
else
{
DisplayAlert("Not Allowed:", "No sound is currently playing!", "Close");
}
}
private void PauseButton_Click(object sender, EventArgs e)
{
if (player != null)
{
if (player.IsPlaying)
{
player.Pause();
PauseButton.IsVisible = false;
PlayButton.IsVisible = true;
PlayButton.Background = new SolidColorBrush(Colors.LightBlue);
}
else
{
player.Play();
PlayButton.IsVisible = false;
}
}
else
{
DisplayAlert("Not Allowed:", "No sound is currently playing!", "Close");
}
}
private void LoopButton_Click(object sender, EventArgs e)
{
player.Loop = true;
LoopButton.Background = new SolidColorBrush(Colors.LightGreen);
StopButton.Background = new SolidColorBrush(Colors.OrangeRed);
}
private void StopButton_Clicked(object sender, EventArgs e)
{
PauseButton.IsVisible = true;
PlayButton.IsVisible = false;
player.Loop = false;
player.Stop();
LoopButton.Background = new SolidColorBrush(Colors.LightGray);
StopButton.Background = new SolidColorBrush(Colors.LightGray);
PauseButton.Background = new SolidColorBrush(Colors.LightGray);
}
private void PlaybackEnded(object sender, EventArgs e)
{
PauseButton.Background = new SolidColorBrush(Colors.LightGray);
StopButton.Background = new SolidColorBrush(Colors.LightGray);
}
private async void ChordList_SelectionChanged(object sender, SelectionChangedEventArgs e)
{
Sound item = (Sound)ChordList.SelectedItem;
player = audioManager.CreatePlayer(await FileSystem.OpenAppPackageFileAsync(item.AudioFile));
// The audio manager can be used without dependency injection as follows
//player = AudioManager.Current.CreatePlayer(await FileSystem.OpenAppPackageFileAsync(item.AudioFile));
player.PlaybackEnded += PlaybackEnded;
player.Play();
PauseButton.IsVisible = true;
PlayButton.IsVisible = false;
PauseButton.Background = new SolidColorBrush(Colors.Orange);
StopButton.Background = new SolidColorBrush(Colors.OrangeRed);
}
// This method generates a List of all the sounds that can
// be selected for play.
//private static List<Sound> getSounds()
//{
// var sounds = new List<Sound>();
// sounds.Add(new Sound("e_1st_string", SoundCategory.Strings));
// sounds.Add(new Sound("b_2nd_string", SoundCategory.Strings));
// sounds.Add(new Sound("g_3rd_string", SoundCategory.Strings));
// sounds.Add(new Sound("d_4th_string", SoundCategory.Strings));
// sounds.Add(new Sound("a_5th_string", SoundCategory.Strings));
// sounds.Add(new Sound("e_6th_string", SoundCategory.Strings));
// sounds.Add(new Sound("c_major", SoundCategory.Scales));
// sounds.Add(new Sound("a_minor", SoundCategory.Scales));
// sounds.Add(new Sound("a_minor_hm", SoundCategory.Scales));
// sounds.Add(new Sound("g_major", SoundCategory.Scales));
// sounds.Add(new Sound("e_minor", SoundCategory.Scales));
// sounds.Add(new Sound("e_minor_hm", SoundCategory.Scales));
// sounds.Add(new Sound("d_major", SoundCategory.Scales));
// sounds.Add(new Sound("b_minor", SoundCategory.Scales));
// sounds.Add(new Sound("b_minor_hm", SoundCategory.Scales));
// sounds.Add(new Sound("f_major", SoundCategory.Scales));
// sounds.Add(new Sound("d_minor", SoundCategory.Scales));
// sounds.Add(new Sound("d_minor_hm", SoundCategory.Scales));
// sounds.Add(new Sound("a_shape", SoundCategory.Shapes));
// sounds.Add(new Sound("c_shape", SoundCategory.Shapes));
// sounds.Add(new Sound("d_shape", SoundCategory.Shapes));
// sounds.Add(new Sound("e_shape", SoundCategory.Shapes));
// sounds.Add(new Sound("g_shape", SoundCategory.Shapes));
// sounds.Add(new Sound("a_minor_etude", SoundCategory.Songs));
// sounds.Add(new Sound("traveler", SoundCategory.Songs));
// sounds.Add(new Sound("tanawha", SoundCategory.Songs));
// sounds.Add(new Sound("sibheagsimhor", SoundCategory.Songs));
// sounds.Add(new Sound("in_memory", SoundCategory.Songs));
// sounds.Add(new Sound("countryroad", SoundCategory.Songs));
// sounds.Add(new Sound("russiandance", SoundCategory.Songs));
// sounds.Add(new Sound("beginnings", SoundCategory.Songs));
// sounds.Add(new Sound("greensleeves", SoundCategory.Songs));
// sounds.Add(new Sound("lyric_tune_iii", SoundCategory.Songs));
// sounds.Add(new Sound("bar_waltz", SoundCategory.Songs));
// return sounds;
//}
}
Hi,
I think the problem is that you are setting player.PlaybackEnded with the method PlaybackEnded instead of an EventHandler.
See below, I added a member playbackEndedEventHandler to your class (see the lines with a comment). This is what you should use for the PlaybackEnded event. I did not test the below code, but I successfully use something similar in my project.
public partial class ChordsPage : ContentPage
{
private readonly IAudioManager audioManager;
IAudioPlayer player;
private readonly EventHandler playbackEndedEventHandler; // <= event handler
public ChordsPage(IAudioManager audioManager)
{
InitializeComponent();
this.audioManager = audioManager;
playbackEndedEventHandler = new EventHandler(PlaybackEnded); // <= instantiate the event handler
}
private void PlaybackEnded(object sender, EventArgs e)
{
PauseButton.Background = new SolidColorBrush(Colors.LightGray);
StopButton.Background = new SolidColorBrush(Colors.LightGray);
}
private async void ChordList_SelectionChanged(object sender, SelectionChangedEventArgs e)
{
Sound item = (Sound)ChordList.SelectedItem;
player = audioManager.CreatePlayer(await FileSystem.OpenAppPackageFileAsync(item.AudioFile));
player.PlaybackEnded += playbackEndedEventHandler; // <= add the event handler instead of the method
player.Play();
}
} On 05/29/2023 10:32 AM EDT JEROME HEISER ***@***.***> wrote:
> On 04/27/2023 10:40 AM EDT Jonathan Godbout ***@***.***> wrote:
>
>
>
> Thank you for the input. I choose not to use this code but instead input the following Xaml to create the media player "myPlayer" and the method "myPlayer_MediaEnded" and it workd just fine.
>
<toolkit:MediaElement Grid.Row="2" Grid.ColumnSpan="2"
x:Name="myPlayer"
MediaEnded="myPlayer_MediaEnded"
ShouldAutoPlay="True"
HorizontalOptions="Center"
VerticalOptions="Center"
WidthRequest="400"/>
…
>
> Hi,
>
> I think the problem is that you are setting player.PlaybackEnded with the method PlaybackEnded instead of an EventHandler.
>
> See below, I added a member playbackEndedEventHandler to your class (see the lines with a comment). This is what you should use for the PlaybackEnded event. I did not test the below code, but I successfully use something similar in my project.
>
> public partial class ChordsPage : ContentPage
> {
> private readonly IAudioManager audioManager;
>
> IAudioPlayer player;
>
> private readonly EventHandler playbackEndedEventHandler; // <= event handler
>
> public ChordsPage(IAudioManager audioManager)
> {
> InitializeComponent();
>
> this.audioManager = audioManager;
>
> playbackEndedEventHandler = new EventHandler(PlaybackEnded); // <= instantiate the event handler
> }
>
> private void PlaybackEnded(object sender, EventArgs e)
> {
> PauseButton.Background = new SolidColorBrush(Colors.LightGray);
> StopButton.Background = new SolidColorBrush(Colors.LightGray);
> }
>
> private async void ChordList_SelectionChanged(object sender, SelectionChangedEventArgs e)
> {
> Sound item = (Sound)ChordList.SelectedItem;
> player = audioManager.CreatePlayer(await FileSystem.OpenAppPackageFileAsync(item.AudioFile));
> player.PlaybackEnded += playbackEndedEventHandler; // <= add the event handler instead of the method
> player.Play();
> }
> }
>
> —
> Reply to this email directly, view it on GitHub #40 (comment), or unsubscribe https://github.com/notifications/unsubscribe-auth/AO37UDNUME7MBGTUNRPFAADXDKANLANCNFSM6AAAAAATCB33EY.
> You are receiving this because you authored the thread.Message ID: ***@***.***>
>
That latest code sample is referring to the MediaElement which comes from the .NET MAUI Community Toolkit and not this project. Which are you using?
Shaun I think I thanked you in the past for your response.
However I have not seen any response to my question about the problems I am having embedding an SQLite file into a .Net Maui application to work on the Android emulator in Visual Studio. I have done a lot of reaserch and try many of the solutions out there on the internet with no avail.
The problem I have currently occurs on the SQLite connection not finding the embedded file that was moved to local storage of the app. The exception thrown is as follows:
On 10/30/2023 1:11 PM EDT Shaun Lawrence ***@***.***> wrote:
That latest code sample is referring to the MediaElement which comes from the .NET MAUI Community Toolkit and not this project. Which are you using?
—
Reply to this email directly, view it on GitHub #40 (comment), or unsubscribe https://github.com/notifications/unsubscribe-auth/AO37UDPQOS3EVCDVRPV7DL3YB7NSNAVCNFSM6AAAAAATCB33E2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVGY4DMOBWHA.
You are receiving this because you authored the thread.
The code that this error occurs in is attached and gets thrown on the "GetTerms()" mehtod when trying to access the database through the connection that was setup. However when I single step through the code when the connection is instaniated and I look at the view is showns that exceptions occured when trying to access the path defined for the connection.
using System;
using System.Collections.Generic;
using System.Linq;
using System.Reflection;
using System.Text;
using System.Threading.Tasks;
using System.Collections.ObjectModel;
namespace jGuitarClass_IV.Persistence
{
public class Database
{
public SQLiteAsyncConnection connection;
public string DbPath = string.Empty;
public Database()
{
// We can’t have async constructors, so wrap the call that creates
// the table in its own async method. We can then call this method
// from our constructor using a discard (_), which will then run
// the method in a thread without blocking the UI.
_ = Initialise();
}
public async Task Initialise()
{
// Check permission for Storage read/write
PermissionStatus status = await Permissions.CheckStatusAsync<Permissions.StorageRead>();
if (status != PermissionStatus.Granted) status = await Permissions.RequestAsync<Permissions.StorageRead>();
status = await Permissions.CheckStatusAsync<Permissions.StorageWrite>();
if (status != PermissionStatus.Granted) status = await Permissions.RequestAsync<Permissions.StorageWrite>();
// var dbDir = FileSystem.AppDataDirectory;
// DbPath = Path.Combine(dbDir, "musicterms.sqlite");
DbPath = System.IO.Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData), "musicterms.sqlite");
// This connection method is used to check if the database
// was created and will create if it does not exist before connecting.
// SQLite includes a lightweight ORM, which allows us to interact with
// the database using POCOs rather than having to write SQL statements
// every time we want to write data to or retrieve data from the
// database, and it also means we can use those POCOs as our table
// definitions.
// If you are not copying a database to the local store then you would
// create a new database as follows:
// await _connection.CreateTableAsync<Terms>();
if (!File.Exists(DbPath))
{
// Only do this when app first runs
// Move the existing database to the local store
var assembly = IntrospectionExtensions.GetTypeInfo(typeof(App)).Assembly;
using (Stream stream = assembly.GetManifestResourceStream("jGuitarClass_IV.Data.musicterms.sqlite"))
{
using (MemoryStream memoryStream = new MemoryStream())
{
stream.CopyTo(memoryStream);
File.WriteAllBytes(DbPath, memoryStream.ToArray());
}
}
}
var dbOptions = new SQLiteConnectionString(DbPath);
connection = new SQLiteAsyncConnection(dbOptions);
}
// Get all terms in the music database
public async Task<List<Terms>> GetTerms()
{
return await connection.Table<Terms>().ToListAsync();
}
// Get a specific music term
public async Task<Terms> GetTerm(int Id)
{
var quwey = connection.Table<Terms>().Where(f => f.Id == Id);
return await quwey.FirstOrDefaultAsync();
}
// Add a new music term to the database
public async Task<int> AddTerm(Terms term)
{
return await connection.InsertAsync(term);
}
// Delete a new music term from the database
public async Task<int> DeleteTerm(Terms term)
{
return await connection.DeleteAsync(term);
}
// Update an existing music term to the database
public async Task<int> UpdateTerm(Terms term)
{
return await connection.UpdateAsync(term);
}
}
}
using jCribScore_III.Models;
using Microsoft.Maui.Storage;
using SQLite;
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Transactions;
namespace jCribScore_III.Persistence
{
public class Database
{
private readonly SQLiteAsyncConnection _connRecords;
private SQLiteAsyncConnection _connSavedData;
private readonly SQLiteAsyncConnection _connMaster;
private readonly SQLiteAsyncConnection _connResults;
private readonly SQLiteAsyncConnection _connGame;
//private SQLiteAsyncConnection _conngrData;
public Database()
{
var dbRecords = new SQLiteConnectionString(MainPage.DrPath);
var dbSavedData = new SQLiteConnectionString(MainPage.DsPath);
var dbMaster = new SQLiteConnectionString(MainPage.DmPath);
var dbResults = new SQLiteConnectionString(MainPage.DmrPath);
var dbGame = new SQLiteConnectionString(MainPage.DgPath);
_connRecords = new SQLiteAsyncConnection(dbRecords);
_connSavedData = new SQLiteAsyncConnection(dbSavedData);
_connMaster = new SQLiteAsyncConnection(dbMaster);
_connResults = new SQLiteAsyncConnection(dbResults);
_connGame = new SQLiteAsyncConnection(dbGame);
_ = InitializeAsync();
}
private async Task InitializeAsync()
{
await _connRecords.CreateTableAsync<GameRecord>();
await _connSavedData.CreateTableAsync<CurrentGame>();
await _connMaster.CreateTableAsync<GameRecord>();
await _connResults.CreateTableAsync<GameResult>();
await _connGame.CreateTableAsync<GameResult>();
return;
}
public async Task ResetGameDatabase()
{
// await _connSavedData.DeleteAllAsync<CurrentGame>();
// First delete the file
string mainDir = System.IO.Path.Combine(FileSystem.Current.AppDataDirectory, MainPage.myDirectory);
string[] picList = Directory.GetFiles(mainDir, "*.sqlite");
foreach (string file in picList)
{
if (file.Contains("SavedData.sqlite"))
{
await _connSavedData.CloseAsync();
File.Delete(file);
var dbSavedData = new SQLiteConnectionString(MainPage.DsPath);
_connSavedData = new SQLiteAsyncConnection(dbSavedData);
}
}
// Then recreate database which allows the ID to be set back to 1
await _connSavedData.CreateTableAsync<CurrentGame>();
}
public async Task DeleteGameResultFile(string name)
{
string mainDir = System.IO.Path.Combine(FileSystem.Current.AppDataDirectory, ".Master");
string[] picList = Directory.GetFiles(mainDir, "*.sqlite");
foreach (string file in picList)
{
if (file.Contains(name))
{
string grpath = Path.Combine(mainDir, name);
var grData = new SQLiteConnectionString(grpath);
var _conngrData = new SQLiteAsyncConnection(grData);
await _conngrData.CloseAsync();
File.Delete(file);
return;
}
}
return;
}
// Return all player records in this computer's database
public async Task<List<GameRecord>> GetRecords()
{
return await _connRecords.Table<GameRecord>().ToListAsync();
}
// Return all player records saved from a previously ongoing game
public async Task<List<CurrentGame>> GetSavedDataAsync()
{
return await _connSavedData.Table<CurrentGame>().ToListAsync();
}
// Return all external game results from the Master database
public async Task<List<GameRecord>> GetMasterAsync()
{
return await _connMaster.Table<GameRecord>().ToListAsync();
}
// Return all player game results from the Game database
public async Task<List<GameResult>> GetGamesAsync(string name)
{
List<GameResult> result = new List<GameResult>();
string mainDir = System.IO.Path.Combine(FileSystem.AppDataDirectory, ".Master");
string grpath = Path.Combine(mainDir, name);
var grData = new SQLiteConnectionString(grpath);
var _conngrData = new SQLiteAsyncConnection(grData);
await _conngrData.CreateTableAsync<GameResult>();
result = await _conngrData.Table<GameResult>().ToListAsync();
await _conngrData.CloseAsync();
return result;
}
// Add a new player's data record to the database
public async Task<int> AddDataRecordAsync(GameRecord data)
{
return await _connRecords.InsertAsync(data);
}
// Add a new player's data record to master records database
public async Task<int> AddMasterRecordAsync(GameRecord data)
{
return await _connMaster.InsertAsync(data);
}
// Add a new player's game result to the game results database
public async Task<int> AddGameResultAsync(GameResult data)
{
return await _connGame.InsertAsync(data);
}
// Add a new player's game result to the master database
public async Task<int> AddToResultsAsync(GameResult data)
{
return await _connResults.InsertAsync(data);
}
// Add current player data from ongoing game to the SavedData database
public async Task<int> AddSavedDataAsync(CurrentGame data)
{
return await _connSavedData.InsertAsync(data);
}
// Add a new player's data record to the Master database
public async Task<int> AddMasterDataAsync(GameRecord data)
{
return await _connMaster.InsertAsync(data);
}
// Update a player's data record in this computer's database
public async Task<int> UpdateDataRecordAsync(GameRecord data)
{
return await _connRecords.UpdateAsync(data);
}
// Update current player data from ongoing game to the SavedData database
public async Task<int> UpdateSavedDataAsync(CurrentGame data)
{
return await _connSavedData.UpdateAsync(data);
}
// Update a player's data record in the Master database
public async Task<int> UpdateMasterDataAsync(GameRecord data)
{
return await _connMaster.UpdateAsync(data);
}
}
}
@jbh630 This is a close and unrelated issue so I won't go into detail here but please feel free to reach out to me and I can offer assistance
Twitter(X)
https://twitter.com/Bijington