Redundant Conformance on Protocol Equatable

Question

Redundant Conformance on Protocol Equatable

wm-j-ray opened this issue 7 years ago · comments

Jack,

I'm getting an error on Dwift.swift line 131 under xCode 9GM, after Swift 4 conversion

public static func diff<Section: Equatable, Value: Equatable>(lhs: SectionedValues<Section, Value>, rhs: SectionedValues<Section, Value>) -> [SectionedDiffStep<Section, Value>]

and I'm certainly not smart enough to fix it without breaking everything. Any help greatly appreciated.

Thank in advance

Jon Rexeisen · Answer 1 · Wed Sep 20 2017 03:40:53 GMT+0800 (China Standard Time)

@wm-j-ray There is a swift 4 branch that takes care of this.

If you can't use that using something like

pod 'Dwifft', :git => 'https://github.com/jflinter/Dwifft.git', :branch => 'swift4'

Then you can change the line

public static func diff<Section: Equatable, Value: Equatable>(lhs: SectionedValues<Section, Value>, rhs: SectionedValues<Section, Value>) -> [SectionedDiffStep<Section, Value>] {

to

public static func diff<Section, Value>(lhs: SectionedValues<Section, Value>, rhs: SectionedValues<Section, Value>) -> [SectionedDiffStep<Section, Value>] {

Bill Ray · Answer 2 · Wed Sep 20 2017 05:46:32 GMT+0800 (China Standard Time)

Got it. Thanks so much.

…

On Sep 19, 2017, 3:40 PM -0400, Jon Rexeisen ***@***.***>, wrote: @wm-j-ray There is a swift 4 branch that takes care of this. If you can't use that using something like pod 'Dwifft', :git => 'https://github.com/jflinter/Dwifft.git', :branch => 'swift4' Then you can change the line public static func diff<Section: Equatable, Value: Equatable>(lhs: SectionedValues<Section, Value>, rhs: SectionedValues<Section, Value>) -> [SectionedDiffStep<Section, Value>] { to public static func diff<Section, Value>(lhs: SectionedValues<Section, Value>, rhs: SectionedValues<Section, Value>) -> [SectionedDiffStep<Section, Value>] { — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.