jfdelnero / HxCModPlayer

A simple and lite MOD (music module) player.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

License

perlun opened this issue · comments

Hi there,

Nice little player you have here. :) I am trying to embed it in a hobbyist OS so that's why I find it more interesting than e.g. libmikmod which is more feature-rich but also much, much more complex.

(We have an existing mod player in our codebase, but the problem is that it crashes on some mods.)

I couldn't find a license in the repository - have you thought about how you want to license the player? I would suggest something liberal like MIT/X11, or BSD if you so prefer. Preferably not the more restrained licenses like Apache, LGPL etc. But, it's of course up to you in the end.

Ah, I saw now in the hxcmod.c file:

// You are free to do what you want with this code.
// A credit is always appreciated if you include it into your prod :)

Very good, thanks for this! It might make sense to add a LICENSE file to the repo to make it even more clear (it will also show the license in the header of the page). I'll try to get a PR submitted about it, one sec.

PR submitted in #4. Closing this, we can continue discussing in the PR.

(Btw, here is the program in which we use this great library of yours: chaos4ever/chaos#154)