Giters

jexia / semaphore

Take control of your data, connect with anything, and expose it anywhere through protocols such as HTTP, GraphQL, and gRPC.

Home Page:https://jexia.github.io/semaphore/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

refactor pkg/specs/template into pkg/specs

veger opened this issue · comments

commented

pkg/specs/template and pkg/specs are tightly coupled (for some miracle template only uses specs and not the other way around as well to get a circular dependency). For unknown reasons they got split into the separate packages by #83 (even looks unrelated to the PR description title).

  • specs.Template and specs.PropertyReference should typically live in the template package, but moving them is impossible (circular dependency).
  • hcl.ParseTemplateProperty() (introduced in #191) should typically move to specs package, but it would also introduce the circular dependency.

So it seems to be best to move template (back) into specs and clean up the issues described above and fix these TODOs related to ParseTemplateProperty():