Unsafe DLL Loading

[Jason A. Donenfeld]

You're using syscall, but you should be using x/sys/windows's lazy DLL struct instead:

damon/win32/base_types_win32.go

Lines 11 to 15 in f4a70e9

 kernel32DLL = syscall.NewLazyDLL("kernel32.dll") 
 advapi32DLL = syscall.NewLazyDLL("advapi32.dll") 
 userenvDLL  = syscall.NewLazyDLL("userenv.dll") 
 psapiDLL    = syscall.NewLazyDLL("psapi.dll") 
 iphlpapiDLL = syscall.NewLazyDLL("iphlpapi.dll") 

iphlpapi.dll and userenv.dll are not part of \KnownDlls.

Your blog post indicates you know about the right way to do it but for some reason didn't.

[Justen Walker]

Thanks for the find @zx2c4. Do you have time to make the PR to fix it?

[Jason A. Donenfeld]

I have no idea what this project does or is used for, but I thought you had an interesting Windows library so I was poking around with it. You're probably a better person to fix this than me.

[Justen Walker]

Sure, just wanted to give you first dibs on fixing it if you were interested. Thank you anyway for reporting, I'll take care of it.

[Jason A. Donenfeld]

By the way, there's an easier way of dealing with all this using //sys. Check it out:

In this file (or in any file, really), I define a bunch of calls like this one:

https://github.com/WireGuard/wireguard-windows/blob/3f40da2044fd468ed05f3902608e62382b81ec9c/tunnel/firewall/syscall_windows.go#L14-L15

And then in this file, I have a go generate directive:

https://github.com/WireGuard/wireguard-windows/blob/3f40da2044fd468ed05f3902608e62382b81ec9c/tunnel/firewall/mksyscall.go#L8

Which winds up creating a file containing the fuction, like:

https://github.com/WireGuard/wireguard-windows/blob/3f40da2044fd468ed05f3902608e62382b81ec9c/tunnel/firewall/zsyscall_windows.go#L39-L52

https://github.com/WireGuard/wireguard-windows/blob/3f40da2044fd468ed05f3902608e62382b81ec9c/tunnel/firewall/zsyscall_windows.go#L90-L100

[Justen Walker]

Neat, I'll take a look at this too. Thanks for the tip!