Son of "fix vulnerabilities without breaking electron-forge CSS"
jessicaschilling opened this issue · comments
Issue #94 tried updating for security vulnerabilities, but stopped with electron-forge 5.2.4 and electron-prebuilt-compile 2.0.8 due to losing support for CSS preprocessors. To quote:
Many security vulnerabilities have crept up since last major changes to Mirada. Fix what can be fixed without going so far as to upgrade electron-forge itself, because there's a known issue with CSS preprocessors: cf electron-userland/electron-forge#601 .
Electron-forge still doesn't support CSS preprocessors, so need to work around.
Version 4.6.0 from #99 ...
The only easy way around the "can't use CSS preprocessors" at present is to just compile the SCSS down to CSS at run and build time. See electron/forge#601 (comment) for what was implemented.
Changes in #99:
- Updated manymany dependency versions
- Added scripts for build-css and watch-css to compile scss into static
compiled css - This required adding node-sass
- Updated version to 4.6.0