jessecambon / tidygeocoder

Geocoding Made Easy

Home Page:https://jessecambon.github.io/tidygeocoder

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

bing batch geocoder doesn't use limit argument

jessecambon opened this issue · comments

The limit argument is not being passed to the bing batch geocoder

a <- geocode(tibble(x = c('paris', 'london')), address = x, full_results = TRUE, method = 'bing', limit = 10, return_input = FALSE, return_addresses = FALSE, verbose = TRUE, mode = 'batch')

Output:

Number of Unique Addresses: 2
Executing batch geocoding...

Batch limit: 50
Passing 2 addresses to the bing batch geocoder
Querying API URL: http://spatial.virtualearth.net/REST/v1/Dataflows/Geocode
Passing the following parameters to the API:
key : "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
input : "pipe"


Bing: Batch job:
Created (HTTP 201).
Bing: Pending
Bing: Completed
Created (HTTP 201).
Bing: Processed: 2 | Succeeded: 2 | Failed: 0
Bing: Batch job processed in: 19.7 seconds
Query completed in: 20.2 seconds

2 rows are returned (one for paris and one for london).

I may be mixing providers (I added a few), but I think I made this on purpose. Limit is not a valid parameter on the API

https://docs.microsoft.com/en-us/bingmaps/spatial-data-services/geocode-dataflow-api/create-a-geocode-job-and-upload-data