jeromeetienne / threex.domevents

three.js extension which provide dom events inside your 3d scene.

Home Page:http://jeromeetienne.github.io/threex.domevents/examples/demo.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Need browserify support

Deadarius opened this issue · comments

Three js currently supports browserify. But in this case it's impossible to use threex.domevents because it expects THREE on the global scope. Can you please confirm if this project is still maintained and I will get pull request accepted quickly if I do one?

i would accept if it isnt intrusive in the code.

btw im quite surprised at the claim 'three.js support browserify'. can you please point at the matching code?

I see your point, I will do it in a little bit less invasive way and submit another pull request if that's ok with you.

Regarding three.js browserify support - https://github.com/mrdoob/three.js/blob/master/src/Three.js#L9

make that a oneliner with a comment and im cool, thanks :)

On Wed, Apr 8, 2015 at 4:20 AM, Alex Lapa notifications@github.com wrote:

I see your point, I will do it in a little bit less invasive way and
submit another pull request if that's ok with you.

Regarding three.js browserify support -
https://github.com/mrdoob/three.js/blob/master/src/Three.js#L9


Reply to this email directly or view it on GitHub
#7 (comment)
.

Added basic support for browserify, pull request here:
nitaigao#5