jeremyevans / tilt

Generic interface to multiple Ruby template engines

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"bin/tilt#test_0008_should support -y for layout file" test failure without erubi

voxik opened this issue · comments

Trying to run the test suite on Fedora, I observe the following test error:

$ LANG=C.UTF-8 ruby -e 'Dir.glob "./test/**/*_test.rb", &method(:require)'

... snip ...

  1) Failure:
bin/tilt#test_0008_should support -y for layout file [/builddir/build/BUILD/tilt-2.2.0/usr/share/gems/gems/tilt-2.2.0/test/tilt_cli_test.rb:71]:
--- expected
+++ actual
@@ -1,4 +1,5 @@
 "Before
 Answer: 2
+
 After
 "

As you can see, I am running the test suite without using Bundler and therefore not having all dependencies available. As it turns out, installing erubi fixes the test error. Not sure if you want to make the test case more universal or if ERB as well as erubi should provide the same result.

BTW I don't think this is the right way to use assert_equal:

assert_equal stdout, "Before\nAnswer: 2\n\nAfter\n"

The correct way should be

    assert_equal "Before\nAnswer: 2\n\nAfter\n",  stdout

IOW the expectation is supposed to be the first argument.

Thanks for the report. I'll fix this shortly.