jenkins-infra / plugin-health-scoring

This project aims to introduce a metric system to calculate the health score of each plugin within the Jenkins ecosystem and reflect the final scores on the Plugin Site for the plugin maintainers and users.

Home Page:https://plugin-health.jenkins.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

SCMLinkValidationProbe regexp must not have a folder

alecharp opened this issue · comments

Description of the bug

Part of a problem with the maven-release-plugin, the plugins stored in a module shouldn't have a folder.
This is why we have to set the inherite=false on the scm section of the POM files as in https://github.com/jenkinsci/aws-java-sdk-plugin/blob/8b291cfcda0960e5a97fbbd6c9e752049dc3d422/pom.xml#L32.

Because of that, assuming there is a folder part in the SCM link of a plugin is wrong.

private static final String GH_REGEXP = "https://(?<server>[^/]*)/(?<repo>jenkinsci/[^/]*)(?:/(?<folder>.*))?";
needs to be fixed and the probe should now fail when there is such a "folder".

Thanks @aneveux