param languages is empty, breaks the searching
opensubtitles opened this issue · comments
According the log I can see not very often, but sometimes we get query like this:
https://api.opensubtitles.com/api/v1/subtitles?episode_number=1&languages=moviehash=5716a7688381082d&moviehash_match=only&query=marvel%27s+the+punisher&season_number=1&type=episode
as you can see, languages is empty, so it won't return anything. Please check the code, if this can happen at your side
This seems to be handled by #67
Yes, that pull request basically ensures this doesn't happen, but the issue is that I couldn't get the plugin to produce the query string from above, everything I tried got me this
episode_number=1&languages=&moviehash=5716a7688381082d&moviehash_match=only&query=marvel%27s+the+punisher&season_number=1&type=episode
(notice how there's an & after the =), it also may be worth mentioning that the plugin always sets the page param (which seems to be missing in that example).
Are you sure this is coming from this plugin? @opensubtitles
you are right, it was caused on our side, we are using varnish to make some URL handling (sorting params, url to lower and so on), so it should be fixed now. The problematic URL was for example
https://api.opensubtitles.com/api/v1/subtitles?episode_number=30&languages=id&moviehash=da4dfeb153fc0693&moviehash_match=only&query=Whose+Line+Is+It+Anyway%3f+(US)&season_number=2&type=episode&page=0
please throw some URLs and check their redirect, for example page=0 is not really need there, params should be sorted and lowercase... so we make redirect. Without redirection you will get data faster...
Yeah I noticed the redirects just now, I'll fix those. It also looks like the search endpoint has been changed (again?), I'll continue about that at https://forum.opensubtitles.org/viewtopic.php?f=8&t=17592 since it is not really related to this issue