Restore log level after running tests that modify it.
lardieri opened this issue · comments
Certain tests in the suite deliberately provoke warnings.
- site_github_munger_spec.rb:
GitHub Metadata: site.name is set in _config.yml, but many plugins and themes expect site.title to be used instead. - repository_finder_spec.rb:
Not Installed: No such file or directory - git
However, other tests set the log level to Error, which suppresses warnings:
- edit_link_tag_spec.rb
- integration_spec.rb
Rspec randomizes the order of the tests. If a random seed is chosen that orders the warning tests ahead of the error tests, then the warnings get logged correctly. Example: ./scripts/test --seed 41261
However, if the random seed orders either of the error tests ahead of the warning tests, then the warnings get suppressed. Example: ./scripts/test --seed 60792
Tests that modify the log level should restore it upon completion.
This issue has been automatically marked as stale because it has not been commented on for at least two months.
The resources of the Jekyll team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.
This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions.