"Needy item farming" broken
magnetik89 opened this issue · comments
It shouldn't catch pokemon while active.
Are you running sniping while you have needy item farming or are the pokemon being caught during the fort wander?
@magnetik89 Also, could you post console output that shows this error explicitly?
2016-08-10 19:52:04,433 [poketrainer] [ INFO] Starting Login process...
2016-08-10 19:52:06,607 [poketrainer] [ INFO] Login successful
......
Runtime (h): 0.0, XP/h: 0.0, Pokedex: 119, km walked: 23.65
2016-08-10 19:52:06,646 [poketrainer] [ INFO] Player only has 0 Pokeballs, farming for more...
2016-08-10 19:52:06,647 [poketrainer] [ INFO] Player has changed speed to 20
2016-08-10 19:52:11,512 [poke_catcher] [ INFO] Nearby Pokemon: Kakuna
2016-08-10 19:52:11,814 [poke_catcher] [ INFO] No balls to catch PokeBalls: 0, GreatBalls: 0, MasterBalls: 0, UltraBalls: 0
Potion: 1, Super Potion: 21, Max Potion 0, Hyper Potion 31, Lucky Eggs 0, Razz Berries 3, exiting encounter
2016-08-10 19:52:11,828 [fort_walker] [ INFO] ===============================================
2016-08-10 19:52:11,828 [fort_walker] [ INFO] Total trip distance will be: 26.69 meters
2016-08-10 19:52:11,829 [fort_walker] [ INFO] Walking 8.9m: https://www.google.com/maps/dir/40.7791865,-73.9635348/40.7792103334,-73.9634342001
2016-08-10 19:52:11,845 [fort_walker] [ INFO] Nearest fort distance is 17.79 meters
2016-08-10 19:52:13,974 [fort_walker] [ INFO] Visiting fort... (http://maps.google.com/maps?q=40.779258,-73.963233)
2016-08-10 19:52:13,975 [fort_walker] [ INFO] Fort spun, yielding: XP +50, 2x POKE_BALL, 1x SUPER_POTION
.......
2016-08-10 19:52:17,199 [poke_catcher] [ INFO] Nearby Pokemon: Kakuna
2016-08-10 19:52:17,469 [poke_catcher] [ INFO] Trying initiate catching Pokemon: Kakuna
2016-08-10 19:52:19,617 [poke_catcher] [ INFO] Catching Pokemon: Type: Kakuna CP: 89, IV: 42.22, Lvl: 8.0, LvlWild: 8.0, MaxCP: 266, Score: 89, IV-Norm.: 41
2016-08-10 19:52:19,617 [poke_catcher] [ INFO] Attempting catch with POKE_BALL at 26.65% chance. Try Number: 1
2016-08-10 19:52:22,620 [poke_catcher] [ INFO] Caught Pokemon: Type: Kakuna CP: 89, IV: 42.22, Lvl: 8.0, LvlWild: 8.0, MaxCP: 266, Score: 89, IV-Norm.: 41
2016-08-10 19:52:22,620 [fort_walker] [ INFO] Traveled 8.90 meters of 26.69 of the trip
2016-08-10 19:52:06,646 [poketrainer] [ INFO] Player only has 0 Pokeballs, farming for more... is the line that indicates needy item farming has begun. This used to prevent any attempts at catching pokemon until the resume threshold had been reached for total pokeballs. However, as you can see a pokemon is caught as soon as any pokeballs are picked up.
@magnetik89 Just to be extra sure, what is your POKEBALL_CONTINUE_THRESHOLD set to?
from my config
"NEEDY_ITEM_FARMING": {
"ENABLE": true,
"POKEBALL_CONTINUE_THRESHOLD": 50,
"POKEBALL_FARM_THRESHOLD": 10,
"FARM_IGNORE_POKEBALL_COUNT": false,
"FARM_IGNORE_GREATBALL_COUNT": false,
"FARM_IGNORE_ULTRABALL_COUNT": false,
"FARM_IGNORE_MASTERBALL_COUNT": true,
"FARM_OVERRIDE_STEP_SIZE": 20
},
this is probably due to the way the main loop is setup. needy farming pretty much needs it's own loop isolated to work right. may need a rewrite.
Does CATCH_POKEMON need to be set to false along with setting the FARMING option to true, or does the FARMING supersede the former?