Compatibility with latest create-react-app dependencies

Question

Compatibility with latest create-react-app dependencies

camel113 opened this issue 8 years ago · comments

I am not sure to understand this sentence in your readme.
When running a production server locally, make sure you use a different port than 3000, to ensure the service worker does not inadvertantly take control of the development environment.

Can we test service workers locally (with classic method npm start) with your changes?

Adrien B · Answer 1 · Mon Nov 07 2016 20:37:03 GMT+0800 (China Standard Time)

I think your changes do not work with "react-scripts": "0.7.0",

Jeff Posnick · Answer 2 · Tue Nov 08 2016 02:05:47 GMT+0800 (China Standard Time)

Thanks for the heads-up. I haven't had a chance to test this out with react-scripts 0.7.0 yet, and it's entirely possible that the setup needs to be modified. I'll keep this issue open to track that.

(I need a little time to get to it, though.)

Nikhil Dev Chunchu · Answer 3 · Sat Nov 12 2016 15:05:17 GMT+0800 (China Standard Time)

I have react-scripts 0.7.0 as well, and looks like the manifest is getting served with the mime type as text/html. Is there any work around for this?

Jeff Posnick · Answer 4 · Wed Nov 23 2016 06:31:55 GMT+0800 (China Standard Time)

I've updated things with an example of using the latest create-react-app dependency.

Can you take a look at c-r-a-0.6.0...c-r-pwa-0.6.0 and confirm that making those changes to something scaffolded with the latest create-react-app works for you?

Jeff Posnick · Answer 5 · Tue Nov 29 2016 00:12:28 GMT+0800 (China Standard Time)

I've heard from other folks that have confirmed it's working now. Please reopen this issue if you're still seeing issues with react-scripts 0.7.0.

Adrien B · Answer 6 · Tue Nov 29 2016 00:38:59 GMT+0800 (China Standard Time)

Thank you @jeffposnick I do not find the time to check it but I will do it soon ;-) As you said other folks confirmed so I trust them ;-)