jeffmer / micropython-ili9341

Hi,

Great library, it works smoothly with my ESP32 and my TFT screen.

I noticed that the data variable is undefined on this line:

Line 189 in 539b0a1

if data is None:

.

Maybe the function defintion should be:

def _readblock(self, x0, y0, x1, y1, data=None):

If that's the case and if this repo is not dead, I can make a PR.

Cheers! Thanks for your work

I think you are right. I am not sure I ever used this function, happy to accept your PR. Thanks, Jeff

…

Sent from my iPad

On 19 May 2020, at 22:57, JPFrancoia ***@***.***> wrote: Hi, Great library, it works smoothly with my ESP32 and my TFT screen. I noticed that the data variable is undefined on this line: https://github.com/jeffmer/micropython-ili9341/blob/539b0a1198d766901e5b4b118b1b6a706ea1a35d/ili934xnew.py#L189. Maybe the function defintion should be: def _readblock(self, x0, y0, x1, y1, data=None): If that's the case and if this repo is not dead, I can make a PR. Cheers! Thanks for your work — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Done!

Merged, closing. Thanks!

Potential bug in lcd.py