Giters

jeffijoe / typesync

Install missing TypeScript typings for dependencies in your package.json.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

can we have an option to have all @types only on root package.json of monorepo?

sibelius opened this issue · comments

commented

we install @types for all monorepo packages inside root package.json, so we don't need to install them in every single package of the monorepo

can we add an option for this behavior?

it should search all package.json, and install all @types of all packages inside the root package.json

commented

Would it make sense to make this the default behavior instead? I never used monorepos so I don't know the workflow.

commented

For me yes, not sure for everybody else

commented

What happens when different versions of the same package exist? How will code editors figure out that we require v1 of types in a package and v2 in other?

commented

Types should be hooked into the root package.json only if they have same version for all packages.

commented

we always try to upgrade all packages to the same versions

commented

it is better to keep @types in packages they belong