jeffersonRibeiro / react-shopping-cart

🛍️ Simple ecommerce cart application built with Typescript and React

Home Page:https://react-shopping-cart-67954.firebaseapp.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

redundant mapStateToProps in Filter component

saher-elgendy opened this issue · comments

I think this part is redundant as you did not use filters props in the component

const mapStateToProps = state => ({
  filters: state.filters.items
});

export default connect(
  mapStateToProps,
  { updateFilters }
)(Filter);

I think the first argument of connect should be null, or you may have an explanation for this!!

Hi @saher-elgendy ! Thank you for pointing that out, when I got time I will fix.

If you wish to send a PR I will kindly accept.

PR #23 credit goes to @saher-elgendy