Comparing two arrays in componentWillReceiveProps??

[saher-elgendy]

I am confused about that part

componentWillReceiveProps(nextProps) {
    const { filters: nextFilters, sort: nextSort } = nextProps;

    if (nextFilters !== this.props.filters) {
      this.handleFetchProducts(nextFilters, undefined);
    }
  }

You are comparing two arrays which always will return false and this would make your condition always true
[1, 2] === [1, 2] // false

Don't you think that it's a bad behaviour in your code???

[Jefferson Ribeiro]

Haha Thanks! I will review the code and change it, you are totally right.

[Syed Saad Qamar]

PR #22 credit goes to @saher-elgendy

[saher-elgendy]

@Syed-Saad-Qamar i think every thing is fine now because of your fix . credit goes to you all.

useEffect will solve it too and would be a better practice than deprecated componentWillReceiveProps

[Syed Saad Qamar]

@saher-elgendy Thanks for your kindness, yeah definitely we can use useEffect but the entire project I don't see they are using **hooks **, you can create a separate issue for hooks so I will raise a PR for that.
@jeffersonRibeiro could you please review and if there is no issue found merge it.

Thanks

[Jefferson Ribeiro]

Thanks @saher-elgendy and @Syed-Saad-Qamar !

[Jefferson Ribeiro]

@all-contributors please add @Syed-Saad-Qamar for code

[allcontributors]

@jeffersonRibeiro

I've put up a pull request to add @Syed-Saad-Qamar! 🎉

[Jefferson Ribeiro]

@all-contributors please add @saher-elgendy for bug

[allcontributors]

@jeffersonRibeiro

I've put up a pull request to add @saher-elgendy! 🎉