jeffbski / wait-on

wait-on is a cross-platform command line utility and Node.js API which will wait for files, ports, sockets, and http(s) resources to become available

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Latest version no longer compatible with Node 12

robatwilliams opened this issue · comments

In the past couple of days, this seems to have stopped working on Node 12 (v12.22.12):

npx wait-on http://localhost:8080
npx: installed 20 in 4.549s
Unexpected token '.'

I see this package hasn't been released in that period, so presumably something has changed in one of the dependencies (direct or transitive).

I'm aware that Node 12 (LTS) is end of life (https://endoflife.date/nodejs), however the readme of this package states it's supported. This issue arose in an old CI job that was using Node 12 and npx wait-on via https://github.com/cypress-io/circleci-orb

https://github.com/hapijs/joi (direct dependency) 17.8 was released yesterday and includes bumping up some of its dependencies.

They do state that version should be compatible with Node 12 - https://joi.dev/resources/status/#joi

According to this comment support for Node 12 was (being) dropped in joi v17.

As per the maintainer's response on joi#2914, they reverted 17.x (published 17.3 with the previous changes removed) and will release the changes as 18. This project specifies ^17.7.0 so won't pick that up automatically, so should now be fine.