jeff-winn / homebridge-automower-platform

A platform plugin for Homebridge to connect your Husqvarna Automower and Gardena Smart (BETA) robotic lawn mowers to Apple HomeKit.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

AutomowerAccessoryFactory in wrong package

jeff-winn opened this issue · comments

Is your feature request related to a problem? Please describe:
After looking at the codebase I noticed the AutomowerAccessoryFactory class is in the primitives package. This class is definitely not a primitive and sets up the behavior of every mower exposed by the plug-in.

Describe the solution you'd like:
This class needs to be relocated out of the primitives to require test coverage.

Describe alternatives you've considered:
Leaving it in place, while already operational would pose a risk for long term support. The risk is likely acceptable given it is a factory.

Additional context:
I likely put it there during initial development before the actual platform factory formed.