lib/slmode.sl lacks keywords “orelse” and “andelse” (patch provided)

[Klaus Alexander Seistrup]

I noticed that the latest commit (68f0c75) doesn't have the keywords orelse and andelse in the lib/slmode.sl file. The attached diff should mitigate that. I've thrown in abs, too, because I use it every now and then.

🙏

---

🔗 slmode.diff

[John E. Davis]

Hi Klaus, The 'orelse' and 'andelse' keywords have been deprecated for quite a while in favor of the more standard && and || short circuit operators. For example, in one of your jedstate files, you have: if (orelse {fpath == NULL} {strlen(fpath) == 0}) return 0; Using the short-circuit operators, this would become: if ((fpath == NULL} || (fpath == "")) return 0; Thanks, --John On Tue, 30 Jan 2024 04:30:27 -0800, Klaus Alexander Seistrup ***@***.***> said:

…

I noticed that the latest commit (68f0c75) doesn't have the keywords `orelse` and `andelse` in the `lib/slmode.sl` file. The attached diff should mitigate that. I've thrown in `abs`, too, because I use it every now and then. :pray: ---- :link: [slmode.diff](https://github.com/jedsoft/jed/files/14097724/slmode-di ff.txt) -- Reply to this email directly or view it on GitHub: #8 You are receiving this because you are subscribed to this thread. Message ID: ***@***.***> ----==_mimepart_65b8ebe3afa17_db172038787c Content-Type: text/html; charset=UTF-8 X-Content-Transfer-Decoded-From: quoted-printable <p></p> <p dir="auto">I noticed that the latest commit (<a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/jedsoft/ jed/commit/68f0c758818442357fccde16f63df226b62e16dc/hovercard" href="68f0c75 b62e16dc"><tt>68f0c75</tt></a>) doesn't have the keywords <code class="notranslate">orelse</code> and <code class="notranslate">andelse</code> in the <code class="notranslate">lib/slmode.sl</code> file. The attached diff should mitigate that. I've thrown in <code class="notranslate">abs</code>, too, because I use it every now and then.</p> <p dir="auto">�</p> <hr> <p dir="auto">� <a href="https://github.com/jedsoft/jed/files/14 097724/slmode-diff.txt">slmode.diff</a></p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash; <br />Reply to this email directly, <a href="#8">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDACBRQU6LYS4ZQR7KE CSTYRDRWHAVCNFSM6AAAAABCRFEXIWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYDONZVGMYTKMA" >unsubscribe</a>.<br />You are receiving this because you are subscribed to >this thread.<img src="https://github.com/notifications/beacon/ABDACBUP6FYQJ >4UZIYPWT7LYRDRWHA5CNFSM6AAAAABCRFEXIWWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LN >MVXHIX3JMTHH3IOCXY.gif" height="1" width="1" alt="" /><span style="color: >transparent; font-size: 0; display: none; visibility: hidden; overflow: >hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; >mso-hide: all">Message ID: <span>&lt;jedsoft/jed/issues/8</span><span>@</sp >an><span>github</span><span>.</span><span>com&gt;</span></span></p> <script type="application/ld+json">[ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#8", "url": "#8", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script> ----==_mimepart_65b8ebe3afa17_db172038787c--

----next-part-90AB0AD265B9345011E2D4D7B4BE1E--

[Klaus Alexander Seistrup]

The 'orelse' and 'andelse' keywords have been deprecated for quite a while in favor of […]

Thanks for letting me know. I actually started with || and &&, but then I read …/doc/text/slang.txt. To be fair, it does say (in sect 7.4) that:

As of S-Lang version 2.1, use of the andelse and orelse have beendeprecated in favor of the && and || short-circuiting operators.

but then it goes on to say

expressions of the form:

expr-1 and expr-2 and ... expr-n

can be replaced by the short circuited version using andelse:

so I got the impression that andelse and orelse were preferred. My fault that I didn't read the first sentence properly. I will revert the change. Thanks!