Unicode issue in Querki Location property
xavidotron opened this issue · comments
I'm not sure exactly what the issue is, but I've noticed a problem in the GBLS Querki. If I put "Café" instead of "Cafe" in the location for an event like https://www.querki.net/u/.2r/.9v5kc4s/#!.7w4gc66, the resulting page or other pages that try to use the field get stuck with the loading spinner and never successfully load.
I've encountered this issue in Chrome on Mac.
Here's an active repro in the Xavetest space: https://www.querki.net/u/xavid/xavetest/#!.9v5kdeu
Weird -- Unicode hasn't been well-tested (after we add localization next
year, I expect that to get more exercise), but it *ought* to work. I'll
look into it -- thanks for pointing it out!
…On Mon, Nov 12, 2018 at 5:47 PM Xavid ***@***.***> wrote:
I'm not sure exactly what the issue is, but I've noticed a problem in the
GBLS Querki. If I put "Café" instead of "Cafe" in the location for an event
like https://www.querki.net/u/.2r/.9v5kc4s/#!.7w4gc66, the resulting page
or other pages that try to use the field get stuck with the loading spinner
and never successfully load.
I've encountered this issue in Chrome on Mac.
Here's an active repro in the Xavetest space:
https://www.querki.net/u/xavid/xavetest/#!.9v5kdeu
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACFW4e57SbtHGFX0jLEL9qRqBlLFmjX_ks5uuem9gaJpZM4Yaekz>
.
Ah, okay -- it's specifically a problem in constructing the map URLs, which
makes sense: Unicode isn't officially legal in URLs. So I need to do a
percent-encoding pass there before constructing the URL. Here's the
official bug report
<https://www.querki.net/u/jducoeur/alpha-issue-tracking/#!.bu6oe4i>, which
I'll try to deal with shortly -- thanks for pointing it out!
…On Mon, Nov 12, 2018 at 6:16 PM Justin du coeur ***@***.***> wrote:
Weird -- Unicode hasn't been well-tested (after we add localization next
year, I expect that to get more exercise), but it *ought* to work. I'll
look into it -- thanks for pointing it out!
On Mon, Nov 12, 2018 at 5:47 PM Xavid ***@***.***> wrote:
> I'm not sure exactly what the issue is, but I've noticed a problem in the
> GBLS Querki. If I put "Café" instead of "Cafe" in the location for an event
> like https://www.querki.net/u/.2r/.9v5kc4s/#!.7w4gc66, the resulting
> page or other pages that try to use the field get stuck with the loading
> spinner and never successfully load.
>
> I've encountered this issue in Chrome on Mac.
>
> Here's an active repro in the Xavetest space:
> https://www.querki.net/u/xavid/xavetest/#!.9v5kdeu
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#5>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACFW4e57SbtHGFX0jLEL9qRqBlLFmjX_ks5uuem9gaJpZM4Yaekz>
> .
>
Okay, fixed -- that will be in the next release...
…On Fri, Nov 16, 2018 at 4:46 PM Justin du coeur ***@***.***> wrote:
Ah, okay -- it's specifically a problem in constructing the map URLs,
which makes sense: Unicode isn't officially legal in URLs. So I need to do
a percent-encoding pass there before constructing the URL. Here's the
official bug report
<https://www.querki.net/u/jducoeur/alpha-issue-tracking/#!.bu6oe4i>,
which I'll try to deal with shortly -- thanks for pointing it out!
On Mon, Nov 12, 2018 at 6:16 PM Justin du coeur ***@***.***>
wrote:
> Weird -- Unicode hasn't been well-tested (after we add localization next
> year, I expect that to get more exercise), but it *ought* to work. I'll
> look into it -- thanks for pointing it out!
>
> On Mon, Nov 12, 2018 at 5:47 PM Xavid ***@***.***> wrote:
>
>> I'm not sure exactly what the issue is, but I've noticed a problem in
>> the GBLS Querki. If I put "Café" instead of "Cafe" in the location for an
>> event like https://www.querki.net/u/.2r/.9v5kc4s/#!.7w4gc66, the
>> resulting page or other pages that try to use the field get stuck with the
>> loading spinner and never successfully load.
>>
>> I've encountered this issue in Chrome on Mac.
>>
>> Here's an active repro in the Xavetest space:
>> https://www.querki.net/u/xavid/xavetest/#!.9v5kdeu
>>
>> —
>> You are receiving this because you are subscribed to this thread.
>> Reply to this email directly, view it on GitHub
>> <#5>, or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/ACFW4e57SbtHGFX0jLEL9qRqBlLFmjX_ks5uuem9gaJpZM4Yaekz>
>> .
>>
>