Convert-HashtableToCode does not work with array of hash tables

[pluma9]

Describe the bug
When passing a hash table, whose one of the values contains an array of hash tables, to Convert-HashtableToCode, the output is not as expected.

To Reproduce

C:\> $department = @{DepartmentName="IT"; Managers = @(@{Name="John"; Age=33}, @{Name="David";  Age = 31})}
C:\> Convert-HashtableToCode $department
@{
        Managers = 'System.Collections.Hashtable','System.Collections.Hashtable'
        DepartmentName = 'IT'
}

Expected behavior
The output should be:

@{
        Managers = @(@{Name="John"; Age=33}, @{Name="David";  Age = 31})
        DepartmentName = 'IT'
}

Desktop (please complete the following information):

• Operating System Version: Windows 10
• Module Version: 2.29.0
• PowerShell Version: 5.1.19041.1
• Powershell Edition: Desktop

[Jeff Hicks]

Sure looks that way. A single hashtable is just fine. I didn't plan for an array. Working on it.

[Jeff Hicks]

Update to v2.30.0 and try again.

[pluma9]

The issue still persists in v2.30.0.

C:\> $department = @{DepartmentName="IT"; Managers = @(@{Name="John"; Age=33}, @{Name="David";  Age = 31})}
C:\> Convert-HashtableToCode $department
@{
        Managers = @{
        Age = 33
        Name = 'John'
},
@{
        Age = 31
        Name = 'David'
}
        DepartmentName = 'IT'
}

The expected output is:

@{
        Managers = @(
        @{
            Age = 33
            Name = 'John'
        },
        @{
            Age = 31
            Name = 'David'
        })
        DepartmentName = 'IT'
}

[Jeff Hicks]

So your issue is the format or alignment? There was in fact a problem if there was an array of hashtables which I've fixed. The result is still usable and valid. Putting the array inside the @() isn't technically required. The result from the function and your expected result are functionally identical.

[pluma9]

I was talking about the structure of the hash table. However, it's my mistake thinking the actual output and the expected output are different. Confirm that the issue has been fixed. Thanks @jdhitsolutions.

[Jeff Hicks]

I made some additional changes in v2.31.0 to explicitly add @() for arrays. The output may still not be perfect but it should only take a moment to edit the result to meet your preferences or requirements.

[pluma9]

It looks good to me. Thanks @jdhitsolutions.