java.lang primitives serialization - JDK-8256358 - JDK 17 support

Question

java.lang primitives serialization - JDK-8256358 - JDK 17 support

mvangoor opened this issue 3 years ago · comments

Hi,

In JDK 16 the default for illegal-access switched to deny (was permit) and in 17 this option was removed completely.
For context see:

https://bugs.openjdk.java.net/browse/JDK-8256358
google/gson#1916 (GSON has similar issue)

Basically every java.lang class cannot be serialized anymore and will throw an java.lang.IllegalAccessException starting JDK16 (can be changed) and perm since JDK17.

The Exception is silently ignored at https://github.com/jdereg/json-io/blob/master/src/main/java/com/cedarsoftware/util/io/JsonWriter.java#L2305

I could create a custom writer to call "toString()" for any java.lang primitive, but thought it worth opening an issue to get insight in others thoughts so please respond.

Deleted user · Answer 1 · Wed Sep 29 2021 22:53:33 GMT+0800 (China Standard Time)

ping @jdereg

wang wei · Answer 2 · Thu Nov 11 2021 18:35:44 GMT+0800 (China Standard Time)

#156 maybe this help, that fix some issues for primitive, better if you can help review..

John DeRegnaucourt · Answer 3 · Thu Nov 11 2021 21:36:54 GMT+0800 (China Standard Time)

#156 added and released. @mvangoor - can you verify if json-io 4.14.0, which contains #156, fixes the issue you were having?

Patrick Oberbichler · Answer 4 · Wed Dec 22 2021 16:58:01 GMT+0800 (China Standard Time)

@jdereg was this version actually released?
According to https://search.maven.org/artifact/com.cedarsoftware/json-io the latest version is still 4.13.0

reuschling · Answer 5 · Wed Mar 16 2022 22:41:35 GMT+0800 (China Standard Time)

Also, the version number in the repo pom.xml is still 4.13.0 I would be happy to help testing the new java17 support. What is the preferred way? Just check it out?

John DeRegnaucourt · Answer 6 · Thu Mar 17 2022 00:05:12 GMT+0800 (China Standard Time)

I appreciate your offer to help get this ready for Java 17. I would recommend that after you pull the project down, run the tests, make sure they are all passing for you. Then, I assume you may make some changes to support Java 17. Create a pull request to get your changes submitted. If you have trouble creating the PR, then send me the changed files and I can incorporate the changes. Assuming all is good, I will incorporate the changes and release a new version. Best regards, John DeRegnaucourt

…

On Wed, Mar 16, 2022, 10:41 AM reuschling ***@***.***> wrote: Also, the version number in the repo pom.xml is still 4.13.0 I would be happy to help testing the new java17 support. What is the preferred way? Just check it out? — Reply to this email directly, view it on GitHub <#154 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABI76TUPQ27WMLRQKQXPK5DVAHXLPANCNFSM5E6EXRSA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

reuschling · Answer 7 · Thu Mar 17 2022 23:45:56 GMT+0800 (China Standard Time)

Ah, I assumed there is java 17 support yet and only testing is left, according to #156. You mentioned you released this as 4.14.0? I don't know what is left. First step would be a number of test cases or simply problematic Objects for test cases. I have seen one test yet in the code here.

Has anybody examples for problematic objects?

I am currently aware of (from the issues):

java.lang.primitives (this issue) => should be addressed by #156 according to @wwang-talend
enum serialization #155 => should be addressed by #156 also
Maybe my issue according deserialisation of records #151

Mike van Goor · Answer 8 · Tue Oct 11 2022 02:35:06 GMT+0800 (China Standard Time)

Hi @jdereg,

First of all sorry for not responding at all.
I lost track of this issue and somehow the messages to remind me got into some obscure trash folder...

That said I recently stumbled upon this sissue 'again' and found this thread with all nice updates!

I manually built the latest master branch as 4.14.0 and tried it out.
So far all tests are passing and primitives are being handled correctly.

I reached out to a few people to also test it and hope to have a final reply asap.

Again sorry for the delay!

Regards,
Mike

John DeRegnaucourt · Answer 9 · Sat Oct 15 2022 05:14:54 GMT+0800 (China Standard Time)

json-io 4.14.0 has been released. The fixes that have been submitted to support JDK through 17 are included. Let me know if you have any issues.

Mike van Goor · Answer 10 · Sat Oct 15 2022 15:29:58 GMT+0800 (China Standard Time)

Hi @jdereg ,

Appreciate the reply, especially since I've been awol for soo long... again truly sorry about that.

I checked the tags and maven repository, I do not see a 4.14.0 there.
Am I missing something? :)

Regards,
Mike

John DeRegnaucourt · Answer 11 · Sat Oct 15 2022 19:30:55 GMT+0800 (China Standard Time)

I released 4.14.0 to Maven Central, however, I forgot to tag the source tree. The repo is now tagged with 4.14.0.

…

On Sat, Oct 15, 2022 at 3:30 AM Mike van Goor ***@***.***> wrote: Hi @jdereg <https://github.com/jdereg> , Appreciate the reply, especially since I've been awol for soo long... again truly sorry about that. I checked the tags and maven repository, I do not see a 4.14.0 there. Am I missing something? :) Regards, Mike — Reply to this email directly, view it on GitHub <#154 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABI76TUYPYBJNEY5HIKF2RTWDJMQBANCNFSM5E6EXRSA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Mike van Goor · Answer 12 · Sun Oct 16 2022 03:49:06 GMT+0800 (China Standard Time)

Thanks, all looking good now.

Closing :)