jdan / 98.css

A design system for building faithful recreations of old UIs

Home Page:https://jdan.github.io/98.css

Repository from Github https://github.comjdan/98.cssRepository from Github https://github.comjdan/98.css

Checkbox cannot center check mark

metropolis-nostalgia opened this issue · comments

Description

Somehow if the label is wrapped into more than one line, the checkbox will be centered, but the check mark (✓) is still not centered, which leave this error:
Checkmark error
Instead of this:
desirable

How to reproduce

The label have to be warped into more than one line.

Removing top: var(--checkmark-top); from the input[type="checkbox"]:checked + label::after declaration on line 420 fixed this issue, and I didn't see any visual changes in the position (even when the lines are not wrapping, so it seems like this doesn't break anything). I only tested it in Brave (Chromium).

Tested this on Safari on MacOS and Chrome on Windows, could not find any visual changes in the position when top: ... was removed. Taking this bug and putting up a PR to fix this