jdalrymple / gitbeaker

🦊🧪 A comprehensive and typed Gitlab SDK for Node.js, Browsers, Deno and CLI

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ProjectRemoteMirrors delete endpoint targets project_aliases

vitamindck opened this issue · comments

commented

The linked code targets a project_aliases endpoint instead of remote_mirrors, which appears to be incorrect based on the context of the file.

remove<E extends boolean = false>(

I think the remove function should be similar to what I pasted below after converted to JS.

remove(projectId, mirrorId, options) {
  return RequestHelper.del()(
    this, 
    endpoint`projects/${projectId}/remote_mirrors/${mirrorId}`, 
    options
  );
}

pull request #3550 is typescript

commented

fixed with #3550