Does not compile on arch linux

Question

Does not compile on arch linux

chitramdasgupta opened this issue 3 years ago · comments

So I did the following:

git clone https://github.com/jdah/jdh-8.git
cd jdh-8
make

And I get the following error:

mkdir -p bin
clang -o emu/emu.o -c emu/emu.c -std=c11 -O0 -g -Wall -Wextra -Wpedantic -Wstrict-aliasing -Wno-pointer-arith -Wno-unused-parameter -Wno-gnu-zero-variadic-macro-arguments
emu/emu.c:21:34: warning: implicit declaration of function 'fileno' is invalid in C99 [-Wimplicit-function-declaration]
    struct pollfd pfds = { .fd = fileno(stdin), .events = POLLIN };
                                 ^
emu/emu.c:35:14: warning: implicit declaration of function 'strcasecmp' is invalid in C99 [-Wimplicit-function-declaration]
        if (!strcasecmp(speed, "realtime")) {
             ^
emu/emu.c:99:5: warning: implicit declaration of function 'strlcpy' is invalid in C99 [-Wimplicit-function-declaration]
    strlcpy(str, text, sizeof(str));
    ^
emu/emu.c:170:19: warning: implicit declaration of function 'fmemopen' is invalid in C99 [-Wimplicit-function-declaration]
        FILE *f = fmemopen((void *) out, n, "wb");
                  ^
emu/emu.c:170:15: warning: incompatible integer to pointer conversion initializing 'FILE *' (aka 'struct _IO_FILE *') with an expression of type 'int' [-Wint-conversion]
        FILE *f = fmemopen((void *) out, n, "wb");
              ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 warnings generated.
clang -o emu/kb.o -c emu/kb.c -std=c11 -O0 -g -Wall -Wextra -Wpedantic -Wstrict-aliasing -Wno-pointer-arith -Wno-unused-parameter -Wno-gnu-zero-variadic-macro-arguments
In file included from emu/kb.c:1:
In file included from emu/emu.h:4:
emu/../common/util.h:39:9: error: unknown type name 'ssize_t'; did you mean 'size_t'?
typedef ssize_t isize;
        ^~~~~~~
        size_t
/usr/lib/clang/12.0.1/include/stddef.h:46:23: note: 'size_t' declared here
typedef __SIZE_TYPE__ size_t;

1 error generated.
make: *** [Makefile:57: emu/kb.o] Error 1

Deleted user · Answer 1 · Wed Aug 25 2021 22:34:32 GMT+0800 (China Standard Time)

Try adding the line #include <sys/types.h> in common/util.h.

Chitram Dasgupta · Answer 2 · Thu Aug 26 2021 02:58:58 GMT+0800 (China Standard Time)

No luck compiling it.

I added #include <sys/types.h> to the file common/util.h

But this still results in compilation errors:

mkdir -p bin
clang -o emu/libemu.o -c emu/libemu.c -std=c11 -O0 -g -Wall -Wextra -Wpedantic -Wstrict-aliasing -Wno-pointer-arith -Wno-unused-parameter -Wno-gnu-zero-variadic-macro-arguments
emu/libemu.c:45:17: warning: implicit declaration of function 'clock_gettime' is invalid in C99 [-Wimplicit-function-declaration]
    u64 start = NOW(),
                ^
emu/libemu.c:15:17: note: expanded from macro 'NOW'
        assert(!clock_gettime(MONO_CLOCK, &ts));            \
                ^
emu/libemu.c:45:17: error: use of undeclared identifier '_CLOCK_MONOTONIC_RAW'
emu/libemu.c:15:31: note: expanded from macro 'NOW'
        assert(!clock_gettime(MONO_CLOCK, &ts));            \
                              ^
emu/libemu.c:10:21: note: expanded from macro 'MONO_CLOCK'
        #define MONO_CLOCK _CLOCK_MONOTONIC_RAW
                           ^
emu/libemu.c:51:15: warning: implicit declaration of function 'clock_gettime' is invalid in C99 [-Wimplicit-function-declaration]
        now = NOW();
              ^
emu/libemu.c:15:17: note: expanded from macro 'NOW'
        assert(!clock_gettime(MONO_CLOCK, &ts));            \
                ^
emu/libemu.c:51:15: error: use of undeclared identifier '_CLOCK_MONOTONIC_RAW'
emu/libemu.c:15:31: note: expanded from macro 'NOW'
        assert(!clock_gettime(MONO_CLOCK, &ts));            \
                              ^
emu/libemu.c:10:21: note: expanded from macro 'MONO_CLOCK'
        #define MONO_CLOCK _CLOCK_MONOTONIC_RAW
                           ^
emu/libemu.c:82:41: warning: implicit declaration of function 'clock_gettime' is invalid in C99 [-Wimplicit-function-declaration]
        u64 sleep_time = ns_per_step - (NOW() - now);
                                        ^
emu/libemu.c:15:17: note: expanded from macro 'NOW'
        assert(!clock_gettime(MONO_CLOCK, &ts));            \
                ^
emu/libemu.c:82:41: error: use of undeclared identifier '_CLOCK_MONOTONIC_RAW'
emu/libemu.c:15:31: note: expanded from macro 'NOW'
        assert(!clock_gettime(MONO_CLOCK, &ts));            \
                              ^
emu/libemu.c:10:21: note: expanded from macro 'MONO_CLOCK'
        #define MONO_CLOCK _CLOCK_MONOTONIC_RAW
                           ^
emu/libemu.c:86:9: warning: implicit declaration of function 'nanosleep' is invalid in C99 [-Wimplicit-function-declaration]
        SLEEP(sleep_time);
        ^
emu/libemu.c:25:13: note: expanded from macro 'SLEEP'
            nanosleep(&req, &rem);                          \
            ^
4 warnings and 3 errors generated.
make: *** [Makefile:57: emu/libemu.o] Error 1

Deleted user · Answer 3 · Thu Aug 26 2021 03:12:17 GMT+0800 (China Standard Time)

Try adding #define _POSIX_C_SOURCE 199309L at the beginning of emu/libemu.c right before #include <time.h>

Chitram Dasgupta · Answer 4 · Mon Aug 30 2021 16:19:55 GMT+0800 (China Standard Time)

I added #define _POSIX_C_SOURCE 199309L at the beginning of emu/libemu.c and I got the following error:

clang -o emu/libemu.o -c emu/libemu.c -std=c11 -O0 -g -Wall -Wextra -Wpedantic -Wstrict-aliasing -Wno-pointer-arith -Wno-unused-parameter -Wno-gnu-zero-variadic-macro-arguments
emu/libemu.c:46:17: error: use of undeclared identifier '_CLOCK_MONOTONIC_RAW'
    u64 start = NOW(),
                ^
emu/libemu.c:16:31: note: expanded from macro 'NOW'
        assert(!clock_gettime(MONO_CLOCK, &ts));            \
                              ^
emu/libemu.c:11:21: note: expanded from macro 'MONO_CLOCK'
        #define MONO_CLOCK _CLOCK_MONOTONIC_RAW
                           ^
emu/libemu.c:52:15: error: use of undeclared identifier '_CLOCK_MONOTONIC_RAW'
        now = NOW();
              ^
emu/libemu.c:16:31: note: expanded from macro 'NOW'
        assert(!clock_gettime(MONO_CLOCK, &ts));            \
                              ^
emu/libemu.c:11:21: note: expanded from macro 'MONO_CLOCK'
        #define MONO_CLOCK _CLOCK_MONOTONIC_RAW
                           ^
emu/libemu.c:83:41: error: use of undeclared identifier '_CLOCK_MONOTONIC_RAW'
        u64 sleep_time = ns_per_step - (NOW() - now);
                                        ^
emu/libemu.c:16:31: note: expanded from macro 'NOW'
        assert(!clock_gettime(MONO_CLOCK, &ts));            \
                              ^
emu/libemu.c:11:21: note: expanded from macro 'MONO_CLOCK'
        #define MONO_CLOCK _CLOCK_MONOTONIC_RAW
                           ^
3 errors generated.
make: *** [Makefile:57: emu/libemu.o] Error 1

_CLOCK_MONOTIC_RAW seems to be the culprit.

Deleted user · Answer 5 · Mon Aug 30 2021 17:04:34 GMT+0800 (China Standard Time)

Instead of doing it in 'libemu.c' do it in 'emu.c' right before the line that says '#include <time.h>'

Chitram Dasgupta · Answer 6 · Tue Aug 31 2021 02:27:08 GMT+0800 (China Standard Time)

But there is no '#include <time.h>' in emu.c

Deleted user · Answer 7 · Tue Aug 31 2021 02:29:22 GMT+0800 (China Standard Time)

My bad, it was only in libemu.c. Replace _CLOCK_MONOTONIC_RAW with CLOCK_MONOTONIC_RAW in libemu.c.

Junxuan Liao · Answer 8 · Tue Aug 31 2021 12:22:58 GMT+0800 (China Standard Time)

On Archlinux, I found out I have to change two more things to build it.

In Makefile, capitalise all occurrence of sdl.
In emu/emu.c, use strncpy instead of strlcpy as it's a BSD thing.

jdh · Answer 9 · Sat Oct 23 2021 00:10:16 GMT+0800 (China Standard Time)

This is all in with ca57c54, can anyone running arch confirm that these changes work?

Junxuan Liao · Answer 10 · Sat Oct 23 2021 11:00:49 GMT+0800 (China Standard Time)

Again, -lSDL2 is needed instead of -lsdl2, and strlcpy isn't a POSIX function. :)

jdh · Answer 11 · Sat Oct 23 2021 19:39:06 GMT+0800 (China Standard Time)

Ah, yeah, can see it's a nonstandard BSD thing.

But on the capitalisation of SDL, is there any easy way to detect Arch specifically (or preferably just the presence of SDL2 over sdl2)? I have no machine to test on.

jdh · Answer 12 · Sat Oct 23 2021 19:53:35 GMT+0800 (China Standard Time)

Okay, Arch should now be fixed. But it depends on ARCH_LINUX := $(shell grep "Arch Linux" /etc/os-release 2>/dev/null) working on Arch, so can anyone confirm now that it works properly?

Junxuan Liao · Answer 13 · Sun Oct 24 2021 08:29:19 GMT+0800 (China Standard Time)

Why not use sdl-config just like on Windows?

Viyaan Chauhan · Answer 14 · Sat Nov 27 2021 21:24:50 GMT+0800 (China Standard Time)

@MikeWalrus I dont think it would work because I dont think sdl-config works on arch linux (and jdah im gonna get an arch vm soon to test it out)

Junxuan Liao · Answer 15 · Sun Nov 28 2021 22:41:59 GMT+0800 (China Standard Time)

@MikeWalrus I dont think it would work because I dont think sdl-config works on arch linux (and jdah im gonna get an arch vm soon to test it out)

I think sdl2-config --cflags --libs do work though.

Viyaan Chauhan · Answer 16 · Mon Dec 13 2021 04:28:49 GMT+0800 (China Standard Time)

@MikeWalrus I dont think it would work because I dont think sdl-config works on arch linux (and jdah im gonna get an arch vm soon to test it out)

I think sdl2-config --cflags --libs do work though.

Probably... you can try

Viyaan Chauhan · Answer 17 · Mon Dec 13 2021 08:12:30 GMT+0800 (China Standard Time)

@chitramdasgupta It works on arch linux...

Viyaan Chauhan · Answer 18 · Mon Dec 13 2021 08:18:25 GMT+0800 (China Standard Time)

This is all in with ca57c54, can anyone running arch confirm that these changes work?

@jdah Yup! It works

Viyaan Chauhan · Answer 19 · Wed Dec 15 2021 04:46:20 GMT+0800 (China Standard Time)

Requesting close to this issue as problem has been fixed