Middleman v4 Support

Question

Middleman v4 Support

jaredpike opened this issue 8 years ago · comments

Currently returns when running Middleman:

/Library/Ruby/Gems/2.0.0/gems/middleman-core-4.1.6/lib/middleman-core/extensions.rb:96:in 'load': Tried to activate old-style extension: title. They are no longer supported. (RuntimeError)

Carl Mercier · Answer 1 · Sat Mar 18 2017 09:41:48 GMT+0800 (China Standard Time)

I've made an attempt at fixing this here: https://github.com/cmer/middleman-title/tree/middleman_4_compatibility

However, I can't get Middleman to recognize the page_title helper. If anybody has an idea why that'd be great.

Carl Mercier · Answer 2 · Sun Apr 02 2017 02:28:10 GMT+0800 (China Standard Time)

I figured out what my issue was.

I have submitted a pull request. Would it be possible to merge please?

Justin Cypret · Answer 3 · Sun Apr 02 2017 08:05:55 GMT+0800 (China Standard Time)

@cmer Nice work! I hadn't gotten around to updating any extensions for Middleman 4 but the new API looks really nice to work with. Thanks for contributing!

I'll push a new version of the gem this evening.