Make TCPServer and BladeAllocServer consistent
jcarreira opened this issue · comments
Right now TCPServer has the attribute max_objects
which is inconsistent with the interface of the RDMAServer (which uses pool_size
).
Both should use a raw count of bytes: pool_size
.
In the same way, tcpservermain should allow setting the size of the server pool as a command line argument (but have default size).
Things to do:
- Make TCPServer use pool_size (number of bytes in the pool) instead of the number of objects. Also, make it an argument of the constructor as in the BladeAllocServer
- Make tcpservermain and bladeallocmain get arguments with the size of the pool (they both should have a default size of 10GB).
- Fix the memory exhaustion test to use a small value for the server pools so that the servers throw an exception earlier. Tests should be quick
Should I set a default size for tcpservermain and bladeallocmain in the event that no size is passed in?
Nevermind, I reread and understand now