jcarreira / cirrus-kv

High-performance key-value store

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix ip/port hardcoded values

jcarreira opened this issue · comments

We should think of getting rid of the IP/port hardcoded values scattered throughout the tests.

A benefit of the hard coded values is that they simplify testing because we only need to call the binary to run the test -- no need to create a custom launch script.

We will need to create a python script to launch these tests.

The IP/port values can come from a few places:

  1. ./configure --test_IP=127.0.0.1 --port=18723
  2. make IP=127.0.0.1 PORT=127.0.0.1 test

@TylerADavis What do you think?

For all components of the system that need this port/ip information, I'd start them with a set of command line args (or a config file), which I'd use to specify this information at runtime (or, rather, start time). I would not do it at compile time.

Yes, agree.

I think we could provide something like

make CONFIG=path_to_config test

to execute a test script that can parse the test config and launch all the tests with the right arguments.

@jcarreira Should we go ahead and close this? or leave it open as only the hardcoded IP values were fixed