jcarreira / cirrus-kv

High-performance key-value store

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix test_mt.cpp test

TylerADavis opened this issue · comments

Test is designed to ensure system works with multiple threads on one client. However, a concurrency issue exists as all threads read and write from the oid 1, thus overwriting one another. Additionally, a memory leak exists as d2 is never freed. As it stands now, the test will likely never pass.

d2 is no longer being created with new, so the memory leak is no longer present.

@jcarreira Should we keep the behavior we have now where all clients share a key space, or should different clients be unable to access one another's keys?