jazzband / django-embed-video

Django app for easy embedding YouTube and Vimeo videos and music from SoundCloud.

Home Page:http://django-embed-video.rtfd.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Option to disable request

eagleoflqj opened this issue · comments

Our website has many YouTube videos on a single template. When the template is rendered, django-embed-video sends a request to verify the thumbnail for each video that asks for it. That adds up to a huge response time.
Do you think it makes sense to have an option at django settings to disable backend requests? If so I'd be glad to send a PR (but I need some time to get familiar to the code base).

Hey @eagleoflqj! That would probably be good if the implementation can be updated to support the disabling as an option. Please feel free to open a PR! It doesn't need to be mergeable right away if you want to e.g. make a WIP or draft version to iterate on together or to gather some feedback from other maintainers :)