Properly trim white space of text nodes

Question

Kleissner opened this issue 6 years ago · comments

Line https://github.com/jaytaylor/html2text/blob/master/html2text.go#L340 should use the strings.TrimSpace function instead of strings.Trim to properly trim white spaces (especially unicode ones).

data = strings.TrimSpace(spacingRe.ReplaceAllString(node.Data, " "))

J. Elliot Taylor · Answer 1 · Mon Mar 11 2019 13:34:45 GMT+0800 (China Standard Time)

Thanks, and sorry about only seeing this now.

I'll gladly accept a PR for this one!

Mike McCrary · Answer 2 · Wed Mar 27 2019 03:56:54 GMT+0800 (China Standard Time)

@jaytaylor - I've created PR #34 for this. Let me know how it looks, thanks!

Mike McCrary · Answer 3 · Tue Apr 09 2019 03:51:36 GMT+0800 (China Standard Time)

@jaytaylor going to bump this incase it got missed

J. Elliot Taylor · Answer 4 · Tue Apr 09 2019 03:59:38 GMT+0800 (China Standard Time)

Hi Mike, thanks for the reminder! Merged it.