javalin / javalin

A simple and modern Java and Kotlin web framework

Home Page:https://javalin.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

⏫ Upgrade to Micrometer 1.13

bogedal opened this issue · comments

Describe the feature
Since Micrometer 1.13 introduces a few breaking changes and have deprecated io.micrometer.prometheus.PrometheusMeterRegistry I would like to see javalin-micrometer bumped to this version.

Additional context
The breaking changes in 1.13 can be see here Migration Guide

@bogedal You want to introduce breaking changes on the current (6x) branch?

Edit: nope we cannot

I have to say @tipsy I see the value in this, we could have an extra module for the newer micrometer until 7.x then drop the old one?

Let's add a Javalin 7 tag and let it age like wine until we bump to jetty12

Hm.. I accidentally merged this from dependabot because the tests passed 🤔

Well we should check our tests and potentially revert the changes